pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Christoph Berg <myon@debian.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Don't trust unvalidated xl_tot_len.
Date: Sun, 12 Nov 2023 09:22:20 +0900
Message-ID: <ZVAavEe8DdyyJEN1@paquier.xyz> (raw)
In-Reply-To: <CA+hUKG+=YFKc7LinctZyqQo6QYfxGEEcPefC9-osZxqEenAV2w@mail.gmail.com>
References: <E1qjozv-005NY4-Rr@gemulon.postgresql.org>
	<ZU5yKecW5yMKKhtp@msg.df7cb.de>
	<ZU6jwsm4XvmAUUTN@msg.df7cb.de>
	<CA+hUKGLm3+2NZX1pEv+2Ky+MmD+nLeBxsNxKYtowepHUnbg8FQ@mail.gmail.com>
	<ZU9rQYbAenlvgpsg@msg.df7cb.de>
	<CA+hUKGJrpmenQWXhTPQ4zqcqzT7e8gKFxrQLL3-9a+Wf1zrxtQ@mail.gmail.com>
	<ZU_Hc8aIvKynfYS2@msg.df7cb.de>
	<CA+hUKGL=9x4G6FMDDa9p-BCndjMhbrh05_vYhMj9WyyriNN08Q@mail.gmail.com>
	<ZU_eD-JQCNA1tPSp@msg.df7cb.de>
	<CA+hUKG+=YFKc7LinctZyqQo6QYfxGEEcPefC9-osZxqEenAV2w@mail.gmail.com>

On Sun, Nov 12, 2023 at 12:17:54PM +1300, Thomas Munro wrote:
> No opinion on potential advantages to other approaches, but I don't
> see why this way shouldn't be expected to work.  So I hope you can
> drop that diff.

Another thing that could be done in stable branches is just to switch
039_end_of_wal.pl to hardcoded values for $XLP_PAGE_MAGIC and
$XLP_FIRST_IS_CONTRECORD.  This is not going to change in a released
version anyway, so there's no real maintenance cost.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (18+ messages)

Message-ID: <ZVAavEe8DdyyJEN1@paquier.xyz>
Permalink:  ../ZVAavEe8DdyyJEN1@paquier.xyz/
Also on:    postgresql.org/message-id/ZVAavEe8DdyyJEN1@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, thomas.munro@gmail.com, myon@debian.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Don't trust unvalidated xl_tot_len.
  In-Reply-To: <ZVAavEe8DdyyJEN1@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox