From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Álvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Nathan Bossart <nathan@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent redeclaration of typedef TocEntry.
Date: Sat, 5 Apr 2025 08:13:12 -0500
Message-ID: <Z_EsaH5Mt4BYINTQ@nathan> (raw)
In-Reply-To: <2408468.1743833410@sss.pgh.pa.us>
References: <202504042140.qo66ggw6wzsz@alvherre.pgsql>
<2408468.1743833410@sss.pgh.pa.us>
Sorry, I missed this one last night.
On Sat, Apr 05, 2025 at 02:10:10AM -0400, Tom Lane wrote:
> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org> writes:
>> ... AFAICS we could move both DefnDumperPtr and
>> DataDumperPtr typedefs to pg_backup_archiver.h, together with struct
>> _tocEntry (the only place where they are used), and we'd have less of a
>> mess here. Then we don't need struct TocEntry in pg_backup.h anymore.
>
> +1 for this simplification.
This is a better fix. Thanks for taking care of it.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, nathan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent redeclaration of typedef TocEntry.
In-Reply-To: <Z_EsaH5Mt4BYINTQ@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox