From: Michael Paquier <michael@paquier.xyz>
To: Joel Jacobson <joel@compiler.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add pg_get_acl() to get the ACL for a database object
Date: Tue, 9 Jul 2024 08:52:25 +0900
Message-ID: <Zox7ucEfBV0LJGW3@paquier.xyz> (raw)
In-Reply-To: <aa46ce00-17ad-4a87-938f-c66196800129@app.fastmail.com>
References: <E1sPHWu-000GPc-0z@gemulon.postgresql.org>
<3408967.1720107891@sss.pgh.pa.us>
<f2688fb7-add6-43da-b1df-97312a451893@app.fastmail.com>
<ZoctyZzE3UlUSer_@paquier.xyz>
<f2539bff-64be-47f0-9f0b-df85d3cc0432@app.fastmail.com>
<ZoukijRBef4m-VMO@paquier.xyz>
<aa46ce00-17ad-4a87-938f-c66196800129@app.fastmail.com>
On Mon, Jul 08, 2024 at 11:55:28AM +0200, Joel Jacobson wrote:
> Patch didn't apply to HEAD nor on top of any of the previous commits either,
> but I couldn't figure out why based on the .rej files, strange.
> I copy/pasted the parts from the patch to test it. Let me know if you need a
> rebased version of it, in case you will need to do the same, to save some work.
Strange. I have just downloaded v2 again. `patch -p1` and `git am`
are both working here.
> Also noted the below in your last commit:
>
> a6417078c414 has introduced as project policy that new features
> committed during the development cycle should use new OIDs in the
> [8000,9999] range.
>
> 4564f1cebd43 did not respect that rule, so let's renumber pg_get_acl()
> to use an OID in the correct range.
>
> Thanks for the info!
> Will make sure to use the `src/include/catalog/renumber_oids.pl` tool
> for future patches.
No problem. This is the kind of tweaks that are really easy to
forget.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, joel@compiler.org, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add pg_get_acl() to get the ACL for a database object
In-Reply-To: <Zox7ucEfBV0LJGW3@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox