pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file
Date: Tue, 19 Aug 2025 08:24:04 +0900
Message-ID: <aKO2FEbirGYRPwk8@paquier.xyz> (raw)
In-Reply-To: <345438.1755524834@sss.pgh.pa.us>
References: <E1unt88-000RJi-2l@gemulon.postgresql.org>
	<345438.1755524834@sss.pgh.pa.us>

On Mon, Aug 18, 2025 at 09:47:14AM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
> > Move SQL-callable code related to multixacts into its own file
> 
> Couldn't this have removed some #include-s from multixact.c?

Right.  funcapi.h and fmgrprotos.h are direct dependencies, but
looking closer it is also possible to remove four more of them.
--
Michael

Attachments:

multixact-header.patch (text/x-diff, 892B) download
diff --git a/src/backend/access/transam/multixact.c b/src/backend/access/transam/multixact.c
index 886740d2d553..6a7963ccd03f 100644
--- a/src/backend/access/transam/multixact.c
+++ b/src/backend/access/transam/multixact.c
@@ -70,16 +70,12 @@
 
 #include "access/multixact.h"
 #include "access/slru.h"
-#include "access/transam.h"
 #include "access/twophase.h"
 #include "access/twophase_rmgr.h"
-#include "access/xact.h"
 #include "access/xlog.h"
 #include "access/xloginsert.h"
 #include "access/xlogutils.h"
 #include "commands/dbcommands.h"
-#include "funcapi.h"
-#include "lib/ilist.h"
 #include "miscadmin.h"
 #include "pg_trace.h"
 #include "pgstat.h"
@@ -87,7 +83,6 @@
 #include "storage/pmsignal.h"
 #include "storage/proc.h"
 #include "storage/procarray.h"
-#include "utils/fmgrprotos.h"
 #include "utils/guc_hooks.h"
 #include "utils/injection_point.h"
 #include "utils/memutils.h"

  signature.asc (application/pgp-signature, 832B) download

view thread (16+ messages)  latest in thread

Message-ID: <aKO2FEbirGYRPwk8@paquier.xyz>
Permalink:  ../aKO2FEbirGYRPwk8@paquier.xyz/
Also on:    postgresql.org/message-id/aKO2FEbirGYRPwk8@paquier.xyz

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file
  In-Reply-To: <aKO2FEbirGYRPwk8@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox