From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org, Sami Imseih <samimseih@gmail.com>
Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats
Date: Mon, 8 Dec 2025 13:53:32 +0900
Message-ID: <aTZZzFhQTtUKWGLm@paquier.xyz> (raw)
In-Reply-To: <2899652.1765167313@sss.pgh.pa.us>
References: <E1vSSCn-003N0Z-2i@gemulon.postgresql.org>
<2899652.1765167313@sss.pgh.pa.us>
On Sun, Dec 07, 2025 at 11:15:13PM -0500, Tom Lane wrote:
> I think that this is really a bug in the Xversion-update test, because
> I don't see why we'd be holding src/test/modules libraries to the
> standard of can-be-upgraded-across-versions. But maybe there's
> something I'm missing?
Yes, I've noticed that a couple of minutes ago, trying to make heads
and tails out of it. I thought that the tets modules libraries were
not getting pulled in the cross-version upgrades but here we are.
From what I can see, this specific failure is caused by
src/test/modules/gin/ where the module has forgotten to drop the
extension injection_points, but there is a total of three modules that
could have hit the problem, as of:
- src/test/modules/nbtree/ (could be hit in the future as it uses
injection_points).
- src/test/modules/gin/
- src/test/modules/typcache/
And I was wondering whether I should just plant more items in
AdjustUpgrade.pm, like in the attached. We need that for gin when
dealing with an old server of at least v17, and for typcache with v18.
The nbtree test is so recent that it does not matter.
TestUpgradeXversion.pm has an ON_ERROR_STOP=1 so the version check is
required.
--
Michael
Attachments:0001-Adjust-upgrade-outputs.patch (text/x-diff, 1.1K) download
From b46344c697771e5496e5d837b9e8e6e2d6b88b01 Mon Sep 17 00:00:00 2001
From: Michael Paquier <michael@paquier.xyz>
Date: Mon, 8 Dec 2025 13:51:40 +0900
Subject: [PATCH] Adjust upgrade outputs
---
src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pmindex 7224c286e1df..78d060c989ab 100644--- a/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm+++ b/src/test/perl/PostgreSQL/Test/AdjustUpgrade.pm@@ -102,6 +102,19 @@ sub adjust_database_contents
}
}
+ # Remove databases that are known to cause upgrades to fail because of+ # updates done in the test module injection_points in v19 that these rely+ # on.+ if ($old_version >= 18)+ {+ _add_st($result, 'postgres', 'drop database regression_typcache');+ }++ if ($old_version >= 17)+ {+ _add_st($result, 'postgres', 'drop database regression_gin');+ }+
# avoid no-path-to-downgrade-extension-version issues
if ($dbnames{contrib_regression_test_extensions})
{
--
2.51.0
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, andrew@dunslane.net, samimseih@gmail.com
Subject: Re: pgsql: injection_points: Remove portions related to custom pgstats
In-Reply-To: <aTZZzFhQTtUKWGLm@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox