From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Mark Wong <markwkm@gmail.com>
Subject: Re: pgsql: Change default value of default_toast_compression to "lz4", when
Date: Thu, 5 Mar 2026 07:47:03 +0900
Message-ID: <aai2Z0UQkkHqvSuQ@paquier.xyz> (raw)
In-Reply-To: <1669305.1772663689@sss.pgh.pa.us>
References: <E1vxdV4-002Hkq-1Y@gemulon.postgresql.org>
<CAOYmi+meTT0NbLbnVqOJD5OKwCtHL86PQ+RZZTrn6umfmHyWaw@mail.gmail.com>
<1669305.1772663689@sss.pgh.pa.us>
On Wed, Mar 04, 2026 at 05:34:49PM -0500, Tom Lane wrote:
> By my count, two-thirds of the buildfarm is broken. (100 failing
> animals, 56 working ones have reported since this commit.)
>
> We would not normally tolerate leaving things that way for any
> great length of time, and I don't think this commit should get
> a pass. I think it needs to be reverted until a very much
> larger fraction of buildfarm owners have prepared for it.
Hmm. If you guys feel strongly about it, I'd be OK to revert. Now
there is a way to split the pie into two halves: we can still
introduce DEFAULT_TOAST_COMPRESSION and use lz4 as default for the GUC
if lz4 is included in the build but, leave the switch of --with-lz4 to
--without-lz4 out of the equation. This choice would leave the
buildfarm in piece, and it still achieves the goal of enabling LZ4 in
TOAST by default, as long as --without-lz4 is used. As long as the
latter is achieved, the point of the change would be made.
Opinions?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, jacob.champion@enterprisedb.com, pgsql-hackers@postgresql.org, markwkm@gmail.com
Subject: Re: pgsql: Change default value of default_toast_compression to "lz4", when
In-Reply-To: <aai2Z0UQkkHqvSuQ@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox