From: Anton A. Melnikov <a.melnikov@postgrespro.ru>
To: John Naylor <john.naylor@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: John Naylor <john.naylor@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move gramparse.h to src/backend/parser
Date: Wed, 15 Oct 2025 10:48:58 +0300
Message-ID: <ac5ebc67-9a2f-4a95-88b2-7ac09e63dc3e@postgrespro.ru> (raw)
In-Reply-To: <CAFBsxsGCoEpiSWUBxnkKFq5S0oNtfB9P+rOjXtgiNLZYDfXa5w@mail.gmail.com>
References: <E1oYJbR-000FbR-LP@gemulon.postgresql.org>
<2862807.1663184226@sss.pgh.pa.us>
<20220914205715.xbmuqox5htobzggy@awork3.anarazel.de>
<20220914210427.y26tkagmxo5wwbvp@awork3.anarazel.de>
<CAFBsxsGCoEpiSWUBxnkKFq5S0oNtfB9P+rOjXtgiNLZYDfXa5w@mail.gmail.com>
Hi!
On 15.09.2022 06:52, John Naylor wrote:
> On Thu, Sep 15, 2022 at 4:04 AM Andres Freund <andres@anarazel.de> wrote:
>>
>> The most general solution I can see would be
>>
>> diff --git i/src/backend/common.mk w/src/backend/common.mk
>> index fa96a82b1a0..61861f5c7eb 100644
>> --- i/src/backend/common.mk
>> +++ w/src/backend/common.mk
>> @@ -23,6 +23,7 @@ objfiles.txt: Makefile $(SUBDIROBJS) $(OBJS)
>>
>> ifeq ($(with_llvm), yes)
>> objfiles.txt: $(patsubst %.o,%.bc, $(OBJS))
>> +$(patsubst %.o,%.bc, $(OBJS)): $(OBJS)
>> endif
>
> Since there have been no other ideas in the past few hours, I will
> push this but it will be a blind attempt since it seems sporadic and
> doesn't happen to reproduce for me.
>
My colleague Marina Polyakova <m.polyakova@postgrespro.ru> found
the similar bug on buildfarm [1] for REL_15_STABLE in the llvm build:
-D_GNU_SOURCE -I/usr/include/libxml2 -flto=thin -emit-llvm -c -o segparse.bc segparse.c
segparse.y:177:10: fatal error: 'segscan.c' file not found
177 | #include "segscan.c"
| ^~~~~~~~~~~
1 error generated
Maybe backpatch [2] to all supported versions not just 16+?
With the best regards,
--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alligator&dt=2025-06-02%2019:07:06
[2] https://github.com/postgres/postgres/commit/16492df70bb25bc99ca3c340a75ba84ca64171b8
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: a.melnikov@postgrespro.ru, john.naylor@enterprisedb.com, andres@anarazel.de, tgl@sss.pgh.pa.us, john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move gramparse.h to src/backend/parser
In-Reply-To: <ac5ebc67-9a2f-4a95-88b2-7ac09e63dc3e@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox