agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Clean up all relid fields of RestrictInfos during join removal.
Date: Tue, 21 Apr 2026 08:02:55 +0900
Message-ID: <aeawnyFl5lwsG2dC@paquier.xyz> (raw)
In-Reply-To: <E1wEtfe-001tkg-1d@gemulon.postgresql.org>
References: <E1wEtfe-001tkg-1d@gemulon.postgresql.org>
Hi Tom,
On Mon, Apr 20, 2026 at 06:48:35PM +0000, Tom Lane wrote:
> Clean up all relid fields of RestrictInfos during join removal.
>
> The original implementation of remove_rel_from_restrictinfo()
> thought it could skate by with removing no-longer-valid relid
> bits from only the clause_relids and required_relids fields.
> This is quite bogus, although somehow we had not run across a
> counterexample before now. At minimum, the left_relids and
> right_relids fields need to be fixed because they will be
> examined later by clause_sides_match_join(). But it seems
> pretty foolish not to fix all the relid fields, so do that.
prion looks unhappy on this one:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2026-04-20%2022%3A50%3A01
This uses -DRELCACHE_FORCE_RELEASE -DCATCACHE_FORCE_RELEASE.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../aeawnyFl5lwsG2dC@paquier.xyz/2-signature.asc)
download
view thread (7+ messages) latest in thread
Message-ID: <aeawnyFl5lwsG2dC@paquier.xyz>
Permalink: ../aeawnyFl5lwsG2dC@paquier.xyz/
Also on: postgresql.org/message-id/aeawnyFl5lwsG2dC@paquier.xyz
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Clean up all relid fields of RestrictInfos during join removal.
In-Reply-To: <aeawnyFl5lwsG2dC@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox