pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().
Date: Thu, 25 Feb 2021 10:49:02 +0100
Message-ID: <afcfb97e-88a1-a540-db95-6c573b93bc2b@eisentraut.org> (raw)
In-Reply-To: <CA+hUKG+im982D-TxHPU=cq=j=GLwFaFvDx8=2JUtwJxj=Fp5LA@mail.gmail.com>
References: <E1lE9OW-0000Sp-3V@gemulon.postgresql.org>
	<2e30284c-1440-a98a-43fe-ad6ebc7a10bb@eisentraut.org>
	<CA+hUKG+im982D-TxHPU=cq=j=GLwFaFvDx8=2JUtwJxj=Fp5LA@mail.gmail.com>

On 23.02.21 08:23, Thomas Munro wrote:
> On Tue, Feb 23, 2021 at 7:03 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>> On 22.02.21 12:28, Thomas Munro wrote:
>>> pg_collation_actual_version() -> pg_collation_current_version().
>>>
>>> The new name seems a bit more natural.
>>>
>>> Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com
>>
>> I don't find where this change was discussed in that thread.  I
>> specifically chose that name to indicate, "not the current version in
>> the database, but the version the OS thinks it should be".  I think the
>> rename loses that distinction.
> 
> I understood "actual" to be a way of contrasting with
> pg_collation.collversion, which we dropped.  Without that, the meaning
> of a more typical function name with "current" seemed clearer to me,
> and "actual" seemed excessively emphatic.  There isn't a concept of a
> single "current version in the database" anymore, there's just the set
> of relevant versions that were current when each index was built.
> Happy to revert the name change if you hate it though, and sorry I
> didn't CC you on the thread.

Seeing that explanation, I think that's even more of a reason to avoid 
the name "current" and use something strikingly different.

In any case, this function name has been around for some years now and 
renaming it just for taste reasons seems unnecessary.





view thread (6+ messages)  latest in thread

Message-ID: <afcfb97e-88a1-a540-db95-6c573b93bc2b@eisentraut.org>
Permalink:  ../afcfb97e-88a1-a540-db95-6c573b93bc2b@eisentraut.org/
Also on:    postgresql.org/message-id/afcfb97e-88a1-a540-db95-6c573b93bc2b@eisentraut.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, thomas.munro@gmail.com
  Subject: Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().
  In-Reply-To: <afcfb97e-88a1-a540-db95-6c573b93bc2b@eisentraut.org>
  References: <E1lE9OW-0000Sp-3V@gemulon.postgresql.org> <2e30284c-1440-a98a-43fe-ad6ebc7a10bb@eisentraut.org> <CA+hUKG+im982D-TxHPU=cq=j=GLwFaFvDx8=2JUtwJxj=Fp5LA@mail.gmail.com> <afcfb97e-88a1-a540-db95-6c573b93bc2b@eisentraut.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox