From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: issue with meson builds on msys2
Date: Tue, 16 May 2023 08:55:20 -0400
Message-ID: <b4162cbb-1e75-8887-b93a-5c82eee3551e@dunslane.net> (raw)
In-Reply-To: <20230515234356.7ysq7w6jjsofeunt@awork3.anarazel.de>
References: <5bddd941-9819-6655-7a71-3f346050583e@dunslane.net>
<6efeb45a-07f9-2291-c8f8-9fb4abbb6ebc@dunslane.net>
<20230427221828.2qo7z4xb4f7islln@awork3.anarazel.de>
<236c0354-62b1-0ae1-a252-4c866bc1c5d6@dunslane.net>
<20230504235413.eibaxlxslo76ipjl@awork3.anarazel.de>
<2ff71af4-cdee-37b8-525a-2b25afd1769a@dunslane.net>
<20230515193817.ttx4qf3ceqeufls2@awork3.anarazel.de>
<26b0ebdb-3e7c-d562-620d-8e2f17286ff9@dunslane.net>
<20230515201326.tbjgfdef6ul6oqfd@awork3.anarazel.de>
<20230515223028.gkctmcoe7jtd5mmw@awork3.anarazel.de>
<20230515234356.7ysq7w6jjsofeunt@awork3.anarazel.de>
On 2023-05-15 Mo 19:43, Andres Freund wrote:
> Hi,
>
> On 2023-05-15 15:30:28 -0700, Andres Freund wrote:
>> As soon as either the pg_ctl for the start, or the whole bash invocation, has
>> stdin redirected, the problem vanishes.
> For a moment I thought this could be related to InheritStdHandles() - but no,
> it doesn't make a difference.
>
> There's loads of handles referencing cygwin alive in pg_ctl.
>
> Based on difference in strace output for bash -c "pg_ctl stop" for the case
> where start redirected stdin (#1) and where not (#2), it looks like some part
> of msys / cygwin sees that stdin is alive when preparing to execute "pg_ctl
> stop", and then runs into trouble.
>
> The way we start the child process on windows makes the use of cmd.exe for
> redirection pretty odd.
>
>
> I couldn't trivially reproduce this with a much simpler case (just nohup
> sleep). Perhaps it's dependent on a wrapper cmd or such.
>
>
I don't know where this all leaves us. It's still more than odd that the
start works fine and the stop doesn't.
This piece of code has worked happily for years. It's only a recent
installation or update of msys2 that's made the problem appear.
I have implemented a workaround where IPC::Run is available - that means
a little extra one-off work for people using msys2, but it's not a huge
burden. Beyond that I don't really want to spend a lot more energy on it.
I suppose the alternative would be to change the way the buildfarm calls
pg_ctl stop. Do you have a concrete suggestion for that?
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: issue with meson builds on msys2
In-Reply-To: <b4162cbb-1e75-8887-b93a-5c82eee3551e@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox