From: Andrew Dunstan <andrew@dunslane.net>
To: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Follow-up fixes for "Make all Perl warnings fatal"
Date: Tue, 2 Jan 2024 09:49:37 -0500
Message-ID: <b936521f-a79e-4ddd-d9a4-1864212d7bb1@dunslane.net> (raw)
In-Reply-To: <E1rJLlz-00CYAB-5m@gemulon.postgresql.org>
References: <E1rJLlz-00CYAB-5m@gemulon.postgresql.org>
On 2023-12-29 Fr 17:56, Peter Eisentraut wrote:
> Follow-up fixes for "Make all Perl warnings fatal"
>
> Mostly, we need to check whether $ENV{PG_TEST_EXTRA} is set before
> doing regular expression matches against it.
This reads a bit oddly to me.
-elsif ($ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)
+elsif (!$ENV{PG_TEST_EXTRA} || $ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)
I think I would have changed it like this
elsif (($ENV{PG_TEST_EXTRA" || "") !~ /\bkerberos\b/)
which is an idiom we've used elsewhere.
Still, TIMTOWTDI.
cheers
andrew (japh)
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Follow-up fixes for "Make all Perl warnings fatal"
In-Reply-To: <b936521f-a79e-4ddd-d9a4-1864212d7bb1@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox