From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Cache by-reference missing values in a long lived context
Date: Thu, 24 Aug 2023 16:36:51 -0400
Message-ID: <ba2150c1-8485-6597-fafe-4fcd39e49c28@dunslane.net> (raw)
In-Reply-To: <3907902.1692890821@sss.pgh.pa.us>
References: <E1qYvJA-000XT3-QX@gemulon.postgresql.org>
<3907902.1692890821@sss.pgh.pa.us>
On 2023-08-24 Th 11:27, Tom Lane wrote:
> Andrew Dunstan<andrew@dunslane.net> writes:
>> Cache by-reference missing values in a long lived context
> The v11 version of this patch is causing a compiler warning for me:
>
> In file included from heaptuple.c:58:
> heaptuple.c: In function 'missing_hash':
> heaptuple.c:97:3: warning: implicit declaration of function 'hash_any'; did you mean 'hash_stats'? [-Wimplicit-function-declaration]
> hash_any((const unsigned char *) entry->value, entry->len));
> ^~~~~~~~
> ../../../../src/include/postgres.h:471:38: note: in definition of macro 'DatumGetUInt32'
> #define DatumGetUInt32(X) ((uint32) (X))
> ^
>
> It seems to work anyway, but please fix.
Sorry about that, fixed.
While we're about it, let's also fix these warnings which are seen on my
systems building releases 11 and 12:
/home/andrew/bf/root/REL_11_STABLE/pgsql.build/../pgsql/src/backend/commands/foreigncmds.c:481:22:
warning: ‘funcargtypes’ may be used uninitialized [-Wmaybe-uninitialized]
/home/andrew/bf/root/REL_12_STABLE/pgsql.build/../pgsql/src/backend/commands/foreigncmds.c:487:22:
warning: ‘funcargtypes’ may be used uninitialized [-Wmaybe-uninitialized]
Maybe funcargtypes here should be initialized to { 0 } ?
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Cache by-reference missing values in a long lived context
In-Reply-To: <ba2150c1-8485-6597-fafe-4fcd39e49c28@dunslane.net>
References: <E1qYvJA-000XT3-QX@gemulon.postgresql.org> <3907902.1692890821@sss.pgh.pa.us> <ba2150c1-8485-6597-fafe-4fcd39e49c28@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox