From: Peter Eisentraut <peter@eisentraut.org>
To: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor libpq state machine for negotiating encryption
Date: Wed, 24 Apr 2024 14:57:15 +0200
Message-ID: <bb3b94da-afc7-438d-8940-cb946e553d9d@eisentraut.org> (raw)
In-Reply-To: <E1rtdlT-001383-HT@gemulon.postgresql.org>
References: <E1rtdlT-001383-HT@gemulon.postgresql.org>
On 08.04.24 03:25, Heikki Linnakangas wrote:
> Refactor libpq state machine for negotiating encryption
>
> This fixes the few corner cases noted in commit 705843d294, as shown
> by the changes in the test.
Either this or something nearby appears to have broken the error
reporting from psql or libpq when failing to get an SSL connection:
PG16:
psql 'sslmode=require host=localhost'
psql: error: connection to server at "localhost" (::1), port 65432
failed: server does not support SSL, but SSL was required
master:
psql 'sslmode=require host=localhost'
psql: error: connection to server at "localhost" (::1), port 65432 failed:
(sic, the output ends after the colon).
This commit removed that detail error message string from the code, but
I don't see any similar message that would take its place.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor libpq state machine for negotiating encryption
In-Reply-To: <bb3b94da-afc7-438d-8940-cb946e553d9d@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox