From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move cancel key generation to after forking the backend
Date: Mon, 29 Jul 2024 18:28:43 +0300
Message-ID: <c72c5e67-4c76-483c-9c93-fb19cfac5da4@iki.fi> (raw)
In-Reply-To: <b8ce284c-18a2-4a79-afd3-1991a2e7d246@iki.fi>
References: <E1sYQGU-001kL9-BT@gemulon.postgresql.org>
<1156B285-B81B-4A5F-A1FE-F1616D216C68@yesql.se>
<bc1e2356-a44d-47a7-a280-c8cb6c625a6a@iki.fi>
<b8ce284c-18a2-4a79-afd3-1991a2e7d246@iki.fi>
On 29/07/2024 17:30, Heikki Linnakangas wrote:
> On 29/07/2024 16:25, Heikki Linnakangas wrote:
>> On 29/07/2024 16:23, Daniel Gustafsson wrote:
>>>> On 29 Jul 2024, at 15:18, Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote:
>>>>
>>>> Move cancel key generation to after forking the backend
>>>
>>> longfin seems a tad sad about this one:
>>>
>>> procsignal.c:87:3: error: redefinition of typedef 'ProcSignalHeader' is a C11 feature [-Werror,-Wtypedef-redefinition]
>>> } ProcSignalHeader;
>>> ^
>>> ../../../../src/include/storage/procsignal.h:77:33: note: previous definition is here
>>> typedef struct ProcSignalHeader ProcSignalHeader;
>>> ^
>>> 1 error generated.
>>> make[4]: *** [procsignal.o] Error 1
>>
>> Yep, thanks, just noticed and fixed it myself. I should add that to the
>> list of compiler options I use...
>
> The --disable-spinlocks animals are still failing, however. Weird. I can
> reproduce it locally, and started to debug but I have no clue what's
> wrong. I'll keep debugging, but I'm all ears if anyone has ideas.
Found & fixed. I released the spinlock twice in EmitProcSignalBarrier. Oops.
I'm a little surprised there isn't an assertion for that. Would be
useful. This might have gone unnoticed for a long time if not for the
--disable-spinlocks implementation, and we've been talking about
removing that.
--
Heikki Linnakangas
Neon (https://neon.tech)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: hlinnaka@iki.fi, daniel@yesql.se, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move cancel key generation to after forking the backend
In-Reply-To: <c72c5e67-4c76-483c-9c93-fb19cfac5da4@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox