From: Peter Eisentraut <peter@eisentraut.org>
To: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
Date: Thu, 6 Nov 2025 10:56:14 +0100
Message-ID: <cd594df7-e677-4e35-9a28-e9e929110339@eisentraut.org> (raw)
In-Reply-To: <e6129aad-0085-4bc3-8b5f-63fbee7b488a@eisentraut.org>
References: <E1vEsbx-004QDO-0o@gemulon.postgresql.org>
<e6129aad-0085-4bc3-8b5f-63fbee7b488a@eisentraut.org>
On 04.11.25 11:40, Peter Eisentraut wrote:
> On 31.10.25 18:08, Álvaro Herrera wrote:
>> pg_createsubscriber: Fix error complaining about the wrong thing
>>
>> The code updates the system identifier, then runs pg_walreset; if the
>> latter fails, it complains about the former, which makes no sense.
>> Change the error message to complain about the right thing.
>
> - pg_log_info("subscriber successfully changed the system identifier");
> + pg_log_info("subscriber successfully reset WAL on the subscriber");
>
> Maybe that message has one "subscriber" too many?
I have fixed this.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, alvherre@kurilemu.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
In-Reply-To: <cd594df7-e677-4e35-9a28-e9e929110339@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox