From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Generate syscache info from catalog files
Date: Tue, 23 Jan 2024 16:31:14 +0100
Message-ID: <d428972e-cb82-4dd8-ba2e-5f695c020752@eisentraut.org> (raw)
In-Reply-To: <4020891.1706018887@sss.pgh.pa.us>
References: <E1rSAY2-002hIk-4y@gemulon.postgresql.org>
<4020891.1706018887@sss.pgh.pa.us>
On 23.01.24 15:08, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> Generate syscache info from catalog files
>
> Per guaibasaurus[1], this commit broke "make dist":
>
> ...
> rm -rf tmp_install/ portlock/
> rm -f config.cache config.log config.status GNUmakefile
> make[1]: Leaving directory '/home/pgsql/buildfarm/buildroot/HEAD/pgsql.build/postgresql-17devel'
> /bin/tar chf postgresql-17devel.tar postgresql-17devel
> /bin/tar: postgresql-17devel/src/include/catalog/syscache_ids.h: File removed before we read it
> /bin/tar: postgresql-17devel/src/include/catalog/syscache_info.h: File removed before we read it
> make: *** [GNUmakefile:94: postgresql-17devel.tar] Error 1
> make: *** Deleting file 'postgresql-17devel.tar'
>
> I'm not sure why --- the makefile changes treat these new files
> exactly like other generated files. It doesn't repro here,
> either, which is odd. It looks like a timing problem, but how
> could there be one?
I have found that the files are not listed in the clean target in
src/include/Makefile. That might explain it, but it's gotta be fixed
anyway. I'll go ahead with that.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Generate syscache info from catalog files
In-Reply-To: <d428972e-cb82-4dd8-ba2e-5f695c020752@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox