From: Peter Eisentraut <peter@eisentraut.org>
To: Aleksander Alekseev <aleksander@timescale.com>
To: pgsql-committers@lists.postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: pgsql: Generate syscache info from catalog files
Date: Mon, 5 Feb 2024 15:50:02 +0100
Message-ID: <bc8d647f-15fa-4a0a-a325-1444495be952@eisentraut.org> (raw)
In-Reply-To: <CAJ7c6TMDGmAiozDjJQ3=P3cd-1BidC_GpitcAuU0aqq-r1eSoQ@mail.gmail.com>
References: <E1rSAY2-002hIk-4y@gemulon.postgresql.org>
<4020891.1706018887@sss.pgh.pa.us>
<d428972e-cb82-4dd8-ba2e-5f695c020752@eisentraut.org>
<4049175.1706027790@sss.pgh.pa.us>
<CAJ7c6TMDGmAiozDjJQ3=P3cd-1BidC_GpitcAuU0aqq-r1eSoQ@mail.gmail.com>
On 05.02.24 13:48, Aleksander Alekseev wrote:
> Hi,
>
>>> I have found that the files are not listed in the clean target in
>>> src/include/Makefile. That might explain it, but it's gotta be fixed
>>> anyway. I'll go ahead with that.
>>
>> Looks like that made guaibasaurus happy, but I'm still mystified
>> as to what was wrong and why it didn't repro elsewhere.
>
> I noticed that catalog/syscache_ids.h is not installed when using
> Meson. This breaks 3rd party extensions like this:
>
> ```
> In file included from
> /Users/eax/projects/c/timescaledb/tsl/test/src/compression_unit_test.c:19:
> /Users/eax/pginstall/include/postgresql/server/utils/syscache.h:23:10:
> fatal error: 'catalog/syscache_ids.h' file not found
> #include "catalog/syscache_ids.h"
> ^~~~~~~~~~~~~~~~~~~~~~~~
> ```
>
> It seems to me that include/catalog/meson.build should be modified,
> however syscache_info.h *is* installed and I don't see why it would be
> processed differently from syscache_ids.h.
The code had this backward accidentally: syscache_ids.h should be
installed, but syscache_info.h not. I have fixed this. Thanks.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, aleksander@timescale.com, pgsql-committers@lists.postgresql.org, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Generate syscache info from catalog files
In-Reply-To: <bc8d647f-15fa-4a0a-a325-1444495be952@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox