pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alena Rybakina <a.rybakina@postgrespro.ru>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection
Date: Tue, 14 Jan 2025 22:29:59 +0300
Message-ID: <d58df4a0-1dbd-4e59-8f41-c0be5877f3a7@postgrespro.ru> (raw)
In-Reply-To: <CAAKRu_b0U_DDFSYP9JNo=GXbHyyGohDgvLj6wkYDsrZxtyg6VA@mail.gmail.com>
References: <CAAKRu_bn7wXa2pwrD-1EOM=dZOW9oNj+cgpALrtzc4k-YbwXJA@mail.gmail.com>
	<202501141821.eiduwdflzxuf@alvherre.pgsql>
	<CAAKRu_b0U_DDFSYP9JNo=GXbHyyGohDgvLj6wkYDsrZxtyg6VA@mail.gmail.com>

On 14.01.2025 22:01, Melanie Plageman wrote:
> On Tue, Jan 14, 2025 at 1:21 PM Alvaro Herrera<alvherre@alvh.no-ip.org>  wrote:
>> On 2025-Jan-13, Melanie Plageman wrote:
>>
>>> I've gone with VACUUM_AUTOVACUUM, VACUUM_COST_DELAY, and
>>> VACUUM_FREEZING, but I am open to feedback.
>> Looks good to me.  I checked these two queries, whose results appear
>> correct:
>>
>> 55432 18devel 560655=# select name, category from pg_settings where category ilike '%vacuum%';
>>                   name                  │              category
>> ───────────────────────────────────────┼─────────────────────────────────────
>>   autovacuum                            │ Vacuuming / Automatic Vacuuming
>>   autovacuum_analyze_scale_factor       │ Vacuuming / Automatic Vacuuming
>>   autovacuum_analyze_threshold          │ Vacuuming / Automatic Vacuuming
>>   autovacuum_freeze_max_age             │ Vacuuming / Automatic Vacuuming
>>   autovacuum_max_workers                │ Vacuuming / Automatic Vacuuming
>>   autovacuum_multixact_freeze_max_age   │ Vacuuming / Automatic Vacuuming
>>   autovacuum_naptime                    │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_cost_delay          │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_cost_limit          │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_insert_scale_factor │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_insert_threshold    │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_scale_factor        │ Vacuuming / Automatic Vacuuming
>>   autovacuum_vacuum_threshold           │ Vacuuming / Automatic Vacuuming
>>   autovacuum_worker_slots               │ Vacuuming / Automatic Vacuuming
>>   vacuum_cost_delay                     │ Vacuuming / Cost-Based Vacuum Delay
>>   vacuum_cost_limit                     │ Vacuuming / Cost-Based Vacuum Delay
>>   vacuum_cost_page_dirty                │ Vacuuming / Cost-Based Vacuum Delay
>>   vacuum_cost_page_hit                  │ Vacuuming / Cost-Based Vacuum Delay
>>   vacuum_cost_page_miss                 │ Vacuuming / Cost-Based Vacuum Delay
>>   vacuum_failsafe_age                   │ Vacuuming / Freezing
>>   vacuum_freeze_min_age                 │ Vacuuming / Freezing
>>   vacuum_freeze_table_age               │ Vacuuming / Freezing
>>   vacuum_multixact_failsafe_age         │ Vacuuming / Freezing
>>   vacuum_multixact_freeze_min_age       │ Vacuuming / Freezing
>>   vacuum_multixact_freeze_table_age     │ Vacuuming / Freezing
>>
>>
>> 55432 18devel 560655=# select name, category from pg_settings where (short_desc ilike '%vacuum%' or extra_desc ilike '%vacuum%') and category not ilike '%vacuum%';
>>              name             │              category
>> ─────────────────────────────┼─────────────────────────────────────
>>   autovacuum_work_mem         │ Resource Usage / Memory
>>   log_autovacuum_min_duration │ Reporting and Logging / What to Log
>>   maintenance_work_mem        │ Resource Usage / Memory
>>   vacuum_buffer_usage_limit   │ Resource Usage / Memory
> Yea, Alena also mentioned these GUCs that are in different groups. I
> think it is okay for these four to remain in their current locations
> as their current groupings seem descriptive enough.
>
Looking at them, I am willing to agree with you

-- 
Regards,
Alena Rybakina
Postgres Professional

view thread (14+ messages)  latest in thread

Message-ID: <d58df4a0-1dbd-4e59-8f41-c0be5877f3a7@postgrespro.ru>
Permalink:  ../d58df4a0-1dbd-4e59-8f41-c0be5877f3a7@postgrespro.ru/
Also on:    postgresql.org/message-id/d58df4a0-1dbd-4e59-8f41-c0be5877f3a7@postgrespro.ru

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: a.rybakina@postgrespro.ru, melanieplageman@gmail.com, tgl@sss.pgh.pa.us, daniel@yesql.se, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection
  In-Reply-To: <d58df4a0-1dbd-4e59-8f41-c0be5877f3a7@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox