From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Joe Conway <mail@joeconway.com>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Apply RLS policies to partitioned tables.
Date: Tue, 13 Jun 2017 13:20:15 +0900
Message-ID: <e056d585-35db-f09d-976f-30fc32776e8a@lab.ntt.co.jp> (raw)
In-Reply-To: <7444.1497275164@sss.pgh.pa.us>
References: <E1dK59q-0005XI-2U@gemulon.postgresql.org>
<10974.1497227727@sss.pgh.pa.us>
<0c5b8b18-262d-de09-50e1-6cf4815d74ab@joeconway.com>
<bea1642d-2791-fe5f-e9cf-df12ea5cf162@lab.ntt.co.jp>
<25990.1497235885@sss.pgh.pa.us>
<89e6ae66-96ee-b6eb-7195-d88dbb988f2f@lab.ntt.co.jp>
<7444.1497275164@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
On 2017/06/12 22:46, Tom Lane wrote:
> Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:
>> How about something like the attached? The patch makes
>> mtstate->mt_plans[0] to be passed for all invocations of ExecInitQual() on
>> WithCheckOption.qual that is being initialized for each partition.
>
> Well, the question then is whether that behaves correctly. Where it would
> matter is if the WCO qual contains a SubPlan, because you'd be adding
> multiple instances of the subplan to the PlanState's list. I think it's
> probably all right, but it might be wise to add a test case where there
> is such a subplan.
>
> Spacing and comment wording seem a bit random in this, too.
Was about to send the updated patch, but noticed that you already
committed it after adding the test. Thanks a lot.
Regards,
Amit
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: Langote_Amit_f8@lab.ntt.co.jp, tgl@sss.pgh.pa.us, mail@joeconway.com
Subject: Re: pgsql: Apply RLS policies to partitioned tables.
In-Reply-To: <e056d585-35db-f09d-976f-30fc32776e8a@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox