From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make all Perl warnings fatal
Date: Sat, 30 Dec 2023 00:33:43 +0100
Message-ID: <eba0f4a4-bfac-4d03-873f-ed3f07fa06a3@eisentraut.org> (raw)
In-Reply-To: <3261739.1703889716@sss.pgh.pa.us>
References: <E1rJGvp-00CWH1-Lj@gemulon.postgresql.org>
<c2c4a65f9598b05b95d36e5025391892f8408eba.camel@j-davis.com>
<CAPpHfdv31WnqELu6ZxE6fS-TqtQMAqLA9AWbK3=CvQBokLj_-A@mail.gmail.com>
<3261739.1703889716@sss.pgh.pa.us>
On 29.12.23 23:41, Tom Lane wrote:
> Alexander Korotkov <aekorotkov@gmail.com> writes:
>> On Fri, Dec 29, 2023 at 10:13 PM Jeff Davis <pgsql@j-davis.com> wrote:
>>> This seems to be causing problems in the buildfarm:
>>> Use of uninitialized value $ENV{"PG_TEST_EXTRA"} in pattern match
>>> (m//) at t/001_mutated_bindpasswd.pl line 23.
>
>> It seems to cause failures for many buildfarm machines.
>
> Presumably, exactly the ones that don't set PG_TEST_EXTRA :-(.
> Peter would not have noticed this if he keeps that set in his
> test environment.
>
> The fix looks simple enough, although a bit tedious because there
> are a bunch of places to change. I can have a go at it if no-one
> else is already on it?
I was already on it. It looks like it's okay now.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, tgl@sss.pgh.pa.us, aekorotkov@gmail.com, pgsql@j-davis.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make all Perl warnings fatal
In-Reply-To: <eba0f4a4-bfac-4d03-873f-ed3f07fa06a3@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox