pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: SQL-standard function body
Date: Fri, 16 Apr 2021 12:26:16 +0200
Message-ID: <f6852374-022c-29ec-4828-ae2c8a4e4668@enterprisedb.com> (raw)
In-Reply-To: <a07142b8d7c541db97bf9403e1646d0fbf6cf614.camel@cybertec.at>
References: <E1lUEF5-00027L-N4@gemulon.postgresql.org>
	<cee01d26fe55bc086b3bcf10bfe4e8d450e2f608.camel@cybertec.at>
	<7466db64eb6abae93e583faf8ca4004d60c163c4.camel@cybertec.at>
	<823c7393-a2ca-c44a-c57a-b5ff84c3de28@enterprisedb.com>
	<a07142b8d7c541db97bf9403e1646d0fbf6cf614.camel@cybertec.at>

On 12.04.21 21:00, Laurenz Albe wrote:
>>> Here is an improved patch, which treats END in the same fashion
>>> (not properly indented for readability).
>>
>> Thanks, I took another look at this and augmented your change with a
>> change that tracks whether the statement starts with CREATE [OR REPLACE]
>> {FUNCTION|PROCEDURE}.  That should make it pretty safe.  What do you think?
> 
> Thanks, that is fine with me and more than I asked for.
> That should definitely exclude all false positive matches.

committed






view thread (18+ messages)  latest in thread

Message-ID: <f6852374-022c-29ec-4828-ae2c8a4e4668@enterprisedb.com>
Permalink:  ../f6852374-022c-29ec-4828-ae2c8a4e4668@enterprisedb.com/
Also on:    postgresql.org/message-id/f6852374-022c-29ec-4828-ae2c8a4e4668@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, laurenz.albe@cybertec.at, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: SQL-standard function body
  In-Reply-To: <f6852374-022c-29ec-4828-ae2c8a4e4668@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox