From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Philipp Gramzow <phil@philphonic.de>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: incoorect restore_command
Date: Thu, 25 Feb 2021 18:03:57 +0900
Message-ID: <06d9fc43-7ea9-20cc-191e-401136bc86fa@oss.nttdata.com> (raw)
In-Reply-To: <YDdJvgQIiBcF6JgR@paquier.xyz>
References: <161397938841.15451.13129264141285167267@wrigleys.postgresql.org>
<YDXo2tIJmkW6mhkm@paquier.xyz>
<478b5b00-5ab3-a1b5-65f4-19b4409c720b@philphonic.de>
<YDYFuW+6Y72vRk9Q@paquier.xyz>
<3c8a08bb-3eaa-cdc6-08f9-3298342722c2@oss.nttdata.com>
<YDdJvgQIiBcF6JgR@paquier.xyz>
On 2021/02/25 15:54, Michael Paquier wrote:
> On Wed, Feb 24, 2021 at 08:15:59PM +0900, Fujii Masao wrote:
>> But I have one question; why do those commands use different
>> archive directories? Isn't it better to use the same one?
>
> storage.sgml uses /var/lib/pgsql/data for the location of the data,
> and the archive path is a mix between /mnt/server/archivedir/ and
> /var/lib/pgsql/archive/. However, the former is used for
> pg_archivecleanup and in postgresql.conf.sample, so why not just using
> /mnt/server/archivedir/ in backup.sgml? Please see the attached.
-archive_command = 'test ! -f /var/lib/pgsql/backup_in_progress || (test ! -f /var/lib/pgsql/archive/%f && cp %p /var/lib/pgsql/archive/%f)'
+archive_command = 'test ! -f /var/lib/pgsql/backup_in_progress || (test ! -f /mnt/server/archivedir/%f && cp %p /mnt/server/archivedir/%f)'
Regarding the section "Standalone Hot Backups", all the directories and
file seem to be placed under /var/lib/pgsql, so at least for me it looks a bit
strange to change only the path of archive directory. So I don't think that
we need to do this change.
-tar -rf /var/lib/pgsql/backup.tar /var/lib/pgsql/archive/
+tar -rf /var/lib/pgsql/backup.tar /mnt/server/archivedir/
Same as above.
-archive_command = 'gzip < %p > /var/lib/pgsql/archive/%f'
+archive_command = 'gzip < %p > /mnt/server/archivedir/%f.gz'
</programlisting>
You will then need to use <application>gunzip</application> during recovery:
<programlisting>
-restore_command = 'gunzip < /mnt/server/archivedir/%f > %p'
+restore_command = 'gunzip < /mnt/server/archivedir/%f.gz > %p'
LGTM. Thanks for the patch!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: masao.fujii@oss.nttdata.com, michael@paquier.xyz, phil@philphonic.de, pgsql-docs@lists.postgresql.org
Subject: Re: incoorect restore_command
In-Reply-To: <06d9fc43-7ea9-20cc-191e-401136bc86fa@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox