public inbox for [email protected]  

help / color / mirror / Atom feed

From: Simon Riggs <[email protected]>
To: Bruce Momjian <[email protected]>
Cc: pgsql-docs <[email protected]>
Subject: Re: Incorrect description of xmax and xip in functions docs
Date: Sun, 07 Sep 2008 12:14:23 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>


On Sat, 2008-09-06 at 21:31 -0400, Bruce Momjian wrote:
> Applied, and attached.

Thanks.

> > And for txid_visible_in_snapshot() comment added:
> > "Function should not be used with subtransaction xids. It is possible
> > that this function will return a true result for a subtransaction xid
> > that was actually still in progress at the time of the snapshot".
> 
> I think the cleaner solution is to throw an appropriate error if a
> subtransaction xid is used, rather than adding documentation.

Or maybe check subtrans for it, as it really should be doing.

-- 
 Simon Riggs           www.2ndQuadrant.com
 PostgreSQL Training, Services and Support

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Incorrect description of xmax and xip in functions docs
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox