pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: petermpallesen@gmail.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples
Date: Tue, 16 Jun 2020 13:39:45 -0400
Message-ID: <1369890.1592329185@sss.pgh.pa.us> (raw)
In-Reply-To: <20200616164108.GA12171@momjian.us>
References: <159195294959.673.5752624528747900508@wrigleys.postgresql.org>
	<20200616103644.GE31175@momjian.us>
	<1300920.1592316494@sss.pgh.pa.us>
	<20200616164108.GA12171@momjian.us>

Bruce Momjian <bruce@momjian.us> writes:
> I have developed the attached patch which is in a better direction.

I still wish you wouldn't jam this topic into an only-marginally-related
sentence.  In the case at hand, the point that the existing text is
making is that a no-op update will fire triggers.  Which is not
something that suppress_redundant_updates_trigger will suppress,
so again it seems confusing to mention that in the same breath.

I think that perhaps the right thing to do is add a new para to
CREATE TRIGGER's "Notes" section, along the lines of

       There are a few built-in trigger functions that can be used
       to solve common problems without having to write your own trigger
       code.  See Section 9.28.

This would have the advantage of covering the other built-in triggers
not only suppress_redundant_updates_trigger.

			regards, tom lane





view thread (8+ messages)  latest in thread

Message-ID: <1369890.1592329185@sss.pgh.pa.us>
Permalink:  ../1369890.1592329185@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1369890.1592329185@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, petermpallesen@gmail.com, pgsql-docs@lists.postgresql.org
  Subject: Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples
  In-Reply-To: <1369890.1592329185@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox