public inbox for [email protected]
help / color / mirror / Atom feedpgrowlocks columns do not match docs: "modes" instead of "lock_type"
2+ messages / 2 participants
[nested] [flat]
* pgrowlocks columns do not match docs: "modes" instead of "lock_type"
@ 2018-10-01 09:42 PG Doc comments form <[email protected]>
2018-10-02 07:41 ` Re: pgrowlocks columns do not match docs: "modes" instead of "lock_type" Michael Paquier <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: PG Doc comments form @ 2018-10-01 09:42 UTC (permalink / raw)
To: [email protected]; +Cc: [email protected]
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/10/static/pgrowlocks.html
Description:
Hi,
The description of the pgrowlocks extension says that the function returns a
column called "lock_type". However this column is really called "modes", as
shown in contrib/pgrowlocks/pgrowlocks--1.2.sql:
CREATE FUNCTION pgrowlocks(IN relname text,
OUT locked_row TID, -- row TID
OUT locker XID, -- locking XID
OUT multi bool, -- multi XID?
OUT xids xid[], -- multi XIDs
OUT modes text[], -- multi XID statuses
OUT pids INTEGER[]) -- locker's process id
RETURNS SETOF record
AS 'MODULE_PATHNAME', 'pgrowlocks'
LANGUAGE C STRICT PARALLEL SAFE;
Thanks, Chris.
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: pgrowlocks columns do not match docs: "modes" instead of "lock_type"
2018-10-01 09:42 pgrowlocks columns do not match docs: "modes" instead of "lock_type" PG Doc comments form <[email protected]>
@ 2018-10-02 07:41 ` Michael Paquier <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Michael Paquier @ 2018-10-02 07:41 UTC (permalink / raw)
To: [email protected]; [email protected]
On Mon, Oct 01, 2018 at 09:42:08AM +0000, PG Doc comments form wrote:
> The description of the pgrowlocks extension says that the function returns a
> column called "lock_type". However this column is really called "modes", as
> shown in contrib/pgrowlocks/pgrowlocks--1.2.sql:
>
> CREATE FUNCTION pgrowlocks(IN relname text,
> OUT locked_row TID, -- row TID
> OUT locker XID, -- locking XID
> OUT multi bool, -- multi XID?
> OUT xids xid[], -- multi XIDs
> OUT modes text[], -- multi XID statuses
> OUT pids INTEGER[]) -- locker's process id
> RETURNS SETOF record
> AS 'MODULE_PATHNAME', 'pgrowlocks'
> LANGUAGE C STRICT PARALLEL SAFE;
0ac5ad5 has updated pgrowlocks from 1.0 to 1.1 and it forgot the
documentation. The order of the columns is correct, but the example was
not. So I updated the documentation with a fresh one, and fixed it all
the way down to 9.3. Thanks for the report, Chris!
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2018-10-02 07:41 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-10-01 09:42 pgrowlocks columns do not match docs: "modes" instead of "lock_type" PG Doc comments form <[email protected]>
2018-10-02 07:41 ` Michael Paquier <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox