public inbox for [email protected]  

help / color / mirror / Atom feed

Default value for the defaultAutoCommit property
2+ messages / 2 participants
[nested] [flat]

* Default value for the defaultAutoCommit property
@ 2021-06-03 07:49 Celinio Fer <[email protected]>
  2021-06-03 10:31 ` Re: Default value for the defaultAutoCommit property Dave Cramer <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Celinio Fer @ 2021-06-03 07:49 UTC (permalink / raw)
  To: [email protected]

Hi,
I wonder if the documentation for the JDBC PostgreSQL driver is up to date :
https://jdbc.postgresql.org/documentation/head/ds-cpds.html#ds-cpds-props
It is written that the default value for the defaultAutoCommit  property  is false.

However in the source code, the default value is true :
https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/ds/PGConnectionPool...

private boolean defaultAutoCommit = true;
...
/**
   * Gets whether connections supplied by this pool will have autoCommit turned on by default. The
   * default value is {@code true}, so that autoCommit will be turned on by default.
   *
   * @return true if connections supplied by this pool will have autoCommit
   */
  public boolean isDefaultAutoCommit() {
    return defaultAutoCommit;
  }

Did i miss something ?
Thanks
Celinio





^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: Default value for the defaultAutoCommit property
  2021-06-03 07:49 Default value for the defaultAutoCommit property Celinio Fer <[email protected]>
@ 2021-06-03 10:31 ` Dave Cramer <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Cramer @ 2021-06-03 10:31 UTC (permalink / raw)
  To: Celinio Fer <[email protected]>; +Cc: [email protected]

Good catch.

Thanks, I will fix that.
Dave Cramer
www.postgres.rocks


On Thu, 3 Jun 2021 at 03:49, Celinio Fer <[email protected]> wrote:

> Hi,
> I wonder if the documentation for the JDBC PostgreSQL driver is up to date
> :
> https://jdbc.postgresql.org/documentation/head/ds-cpds.html#ds-cpds-props
> It is written that the default value for the defaultAutoCommit  property
> is false.
>
> However in the source code, the default value is true :
>
> https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/main/java/org/postgresql/ds/PGConnectionPool...
>
> private boolean defaultAutoCommit = true;
> ...
> /**
>    * Gets whether connections supplied by this pool will have autoCommit
> turned on by default. The
>    * default value is {@code true}, so that autoCommit will be turned on
> by default.
>    *
>    * @return true if connections supplied by this pool will have autoCommit
>    */
>   public boolean isDefaultAutoCommit() {
>     return defaultAutoCommit;
>   }
>
> Did i miss something ?
> Thanks
> Celinio
>
>
>


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2021-06-03 10:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 07:49 Default value for the defaultAutoCommit property Celinio Fer <[email protected]>
2021-06-03 10:31 ` Dave Cramer <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox