pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedMissing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.
6+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2020-11-12 be83aeba84 3f93b3431f 36051198df e60f4a3fc0 658577038f fe709f3e0f 152ed04799 doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
2020-10-27 fbcca6c824 00e4788f20 38e4b15e03 8fde896610 197014baa4 b4395cc87e 8e5d1aef8e Makefile comment: remove reference to tools/thread/thread_test
2020-10-27 d6d7fb1aac 2339038a9b 4066b64290 67b3c3b8c4 d04c4a8f70 1e57c73779 340bbe1fef docs: remove reference to src/tools/thread
* Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.
@ 2020-10-27 10:54 PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 6+ messages in thread
From: PG Doc comments form @ 2020-10-27 10:54 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: e.indrupskaya@postgrespro.ru
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/13/libpq-threading.html
Description:
On page https://www.postgresql.org/docs/13/libpq-exec.html, non-existing
directory is mentioned: src/tools/thread.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.
@ 2020-10-27 16:47 Bruce Momjian <bruce@momjian.us>
parent: PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Momjian @ 2020-10-27 16:47 UTC (permalink / raw)
To: e.indrupskaya@postgrespro.ru; pgsql-docs@lists.postgresql.org
On Tue, Oct 27, 2020 at 10:54:57AM +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/13/libpq-threading.html
> Description:
>
> On page https://www.postgresql.org/docs/13/libpq-exec.html, non-existing
> directory is mentioned: src/tools/thread.
Good find. This directory was removed last week in this commit:
commit 8a2121185b
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed Oct 21 12:08:48 2020 -0400
Remove the option to build thread_test.c outside configure.
Theoretically one could go into src/test/thread and build/run this
program there. In practice, that hasn't worked since 96bf88d52,
and probably much longer on some platforms (likely including just
the sort of hoary leftovers where this test might be of interest).
While it wouldn't be too hard to repair the breakage, the fact that
nobody has noticed for two years shows that there is zero usefulness
in maintaining this build pathway. Let's get rid of it and decree
that thread_test.c is *only* meant to be built/used in configure.
Given that decision, it makes sense to put thread_test.c under config/
and get rid of src/test/thread altogether, so that's what I did.
In passing, update src/test/README, which had been ignored by some
not-so-recent additions of subdirectories.
Discussion: https://postgr.es/m/227659.1603041612@sss.pgh.pa.us
I have applied the attached patch to all branches to remove the
paragraph. I think the docs are only built when there is a minor
release, so it might take a few weeks until the online docs are updated.
You found this very quickly. :-)
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Attachments:
master.diff (text/x-diff, 743B) download
diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index de60281fcb..9ce32fb39b 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -8052,14 +8052,6 @@ int PQisthreadsafe();
<application>libpq</application> source code for a way to do cooperative
locking between <application>libpq</application> and your application.
</para>
-
- <para>
- If you experience problems with threaded applications, run the program
- in <filename>src/tools/thread</filename> to see if your platform has
- thread-unsafe functions. This program is run by
- <filename>configure</filename>, but for binary distributions your
- library might not match the library used to build the binaries.
- </para>
</sect1>
* Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.
@ 2020-10-27 16:54 Tom Lane <tgl@sss.pgh.pa.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 6+ messages in thread
From: Tom Lane @ 2020-10-27 16:54 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: e.indrupskaya@postgrespro.ru; pgsql-docs@lists.postgresql.org
Bruce Momjian <bruce@momjian.us> writes:
> I have applied the attached patch to all branches to remove the
> paragraph.
The removal only happened in HEAD, so I'm unclear on why you back-patched
this doc change?
But thanks for finding the reference; I'd only searched for test/thread,
not tools/thread. Looks like src/template/netbsd has an old reference
too.
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.
@ 2020-10-27 17:21 Bruce Momjian <bruce@momjian.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Momjian @ 2020-10-27 17:21 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: e.indrupskaya@postgrespro.ru; pgsql-docs@lists.postgresql.org
On Tue, Oct 27, 2020 at 12:54:36PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I have applied the attached patch to all branches to remove the
> > paragraph.
>
> The removal only happened in HEAD, so I'm unclear on why you back-patched
> this doc change?
Uh, at the top of all my branches, I typed:
ls */src/tools/thread
and saw no hits in _any_ of the branches. I now see that the problem
wasn't that /src/_tools_/thread was removed but that the docs referenced
it instead of src/_test_/thread. However, it doesn't compile because of
the pg_printf reference. I am thinking removing the paragraph in the
back branches was the right thing to do all along. Agreed?
> But thanks for finding the reference; I'd only searched for test/thread,
> not tools/thread. Looks like src/template/netbsd has an old reference
> too.
Remove that too?
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.
@ 2020-10-27 17:32 Tom Lane <tgl@sss.pgh.pa.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 6+ messages in thread
From: Tom Lane @ 2020-10-27 17:32 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: e.indrupskaya@postgrespro.ru; pgsql-docs@lists.postgresql.org
Bruce Momjian <bruce@momjian.us> writes:
> On Tue, Oct 27, 2020 at 12:54:36PM -0400, Tom Lane wrote:
>> The removal only happened in HEAD, so I'm unclear on why you back-patched
>> this doc change?
> Uh, at the top of all my branches, I typed:
> ls */src/tools/thread
> and saw no hits in _any_ of the branches.
Presumably this text is a leftover from before 8.2:
Author: Bruce Momjian <bruce@momjian.us>
Branch: master Release: REL8_2_BR [9e66c3e6f] 2006-02-04 01:00:02 +0000
Move thread_test directory from /tools to /test so source-only tarballs
have the directory for the configure test.
> I now see that the problem
> wasn't that /src/_tools_/thread was removed but that the docs referenced
> it instead of src/_test_/thread. However, it doesn't compile because of
> the pg_printf reference. I am thinking removing the paragraph in the
> back branches was the right thing to do all along. Agreed?
It probably worked okay on most platforms before v12 (96bf88d52).
We could put back the text and fix where it pointed to, but on the
other hand I'm not sure it's worth the trouble. Obviously nobody
has paid any attention to that para in a long time.
>> But thanks for finding the reference; I'd only searched for test/thread,
>> not tools/thread. Looks like src/template/netbsd has an old reference
>> too.
> Remove that too?
Yeah, I think we could just nuke that line.
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html.
@ 2020-10-27 18:03 Bruce Momjian <bruce@momjian.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: Bruce Momjian @ 2020-10-27 18:03 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: e.indrupskaya@postgrespro.ru; pgsql-docs@lists.postgresql.org
On Tue, Oct 27, 2020 at 01:32:49PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Tue, Oct 27, 2020 at 12:54:36PM -0400, Tom Lane wrote:
> >> The removal only happened in HEAD, so I'm unclear on why you back-patched
> >> this doc change?
>
> > Uh, at the top of all my branches, I typed:
> > ls */src/tools/thread
> > and saw no hits in _any_ of the branches.
>
> Presumably this text is a leftover from before 8.2:
>
> Author: Bruce Momjian <bruce@momjian.us>
> Branch: master Release: REL8_2_BR [9e66c3e6f] 2006-02-04 01:00:02 +0000
>
> Move thread_test directory from /tools to /test so source-only tarballs
> have the directory for the configure test.
>
> > I now see that the problem
> > wasn't that /src/_tools_/thread was removed but that the docs referenced
> > it instead of src/_test_/thread. However, it doesn't compile because of
> > the pg_printf reference. I am thinking removing the paragraph in the
> > back branches was the right thing to do all along. Agreed?
>
> It probably worked okay on most platforms before v12 (96bf88d52).
> We could put back the text and fix where it pointed to, but on the
> other hand I'm not sure it's worth the trouble. Obviously nobody
> has paid any attention to that para in a long time.
I think you are right that removal is appropriate.
> >> But thanks for finding the reference; I'd only searched for test/thread,
> >> not tools/thread. Looks like src/template/netbsd has an old reference
> >> too.
>
> > Remove that too?
>
> Yeah, I think we could just nuke that line.
Removed.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2020-10-27 18:03 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 10:54 Missing directory is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html. PG Doc comments form <noreply@postgresql.org>
2020-10-27 16:47 ` Bruce Momjian <bruce@momjian.us>
2020-10-27 16:54 ` Tom Lane <tgl@sss.pgh.pa.us>
2020-10-27 17:21 ` Bruce Momjian <bruce@momjian.us>
2020-10-27 17:32 ` Tom Lane <tgl@sss.pgh.pa.us>
2020-10-27 18:03 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox