public inbox for [email protected]
help / color / mirror / Atom feedMissing tags ALTER ROUTINE and DROP ROUTINE in Event Trigger Firing Matrix
2+ messages / 2 participants
[nested] [flat]
* Missing tags ALTER ROUTINE and DROP ROUTINE in Event Trigger Firing Matrix
@ 2022-03-05 10:15 PG Doc comments form <[email protected]>
2022-03-09 06:04 ` Re: Missing tags ALTER ROUTINE and DROP ROUTINE in Event Trigger Firing Matrix Michael Paquier <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: PG Doc comments form @ 2022-03-05 10:15 UTC (permalink / raw)
To: [email protected]; +Cc: [email protected]
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/14/event-trigger-matrix.html
Description:
Hi,
"ALTER ROUTINE" and "DROP ROUTINE" are not listed in the "Event Trigger
Firing Matrix" documentation page, even though these tags seem supported
from PostgreSQL 11 onwards.
It would be really usefull to mention them, since alterations and deletions
of functions and procedures through ALTER ROUTINE and DROP ROUTINE commands
won't be caught by a trigger firing only on "ALTER PROCEDURE" and "ALTER
FUNCTION" tags (respectively "DROP PROCEDURE" and "DROP FUNCTION" tags).
Best regards,
--
Leslie Lemaire
Secrétariat général des ministères de la transition écologique, de la
cohésion des territoires et de la mer
Service du numérique
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Missing tags ALTER ROUTINE and DROP ROUTINE in Event Trigger Firing Matrix
2022-03-05 10:15 Missing tags ALTER ROUTINE and DROP ROUTINE in Event Trigger Firing Matrix PG Doc comments form <[email protected]>
@ 2022-03-09 06:04 ` Michael Paquier <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Michael Paquier @ 2022-03-09 06:04 UTC (permalink / raw)
To: [email protected]; [email protected]
Hi Leslie,
On Sat, Mar 05, 2022 at 10:15:33AM +0000, PG Doc comments form wrote:
> "ALTER ROUTINE" and "DROP ROUTINE" are not listed in the "Event Trigger
> Firing Matrix" documentation page, even though these tags seem supported
> from PostgreSQL 11 onwards.
>
> It would be really useful to mention them, since alterations and deletions
> of functions and procedures through ALTER ROUTINE and DROP ROUTINE commands
> won't be caught by a trigger firing only on "ALTER PROCEDURE" and "ALTER
> FUNCTION" tags (respectively "DROP PROCEDURE" and "DROP FUNCTION" tags).
Thanks for the report. Indeed, the table is missing that ALTER
ROUTINE would fire the events ddl_command_start and ddl_command_end.
DROP ROUTINE fires on sql_drop, ddl_command_start and
ddl_command_end. I have applied a patch to add this information
to the docs down to 11.
Regards,
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-03-09 06:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-03-05 10:15 Missing tags ALTER ROUTINE and DROP ROUTINE in Event Trigger Firing Matrix PG Doc comments form <[email protected]>
2022-03-09 06:04 ` Michael Paquier <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox