From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: Jason O'Donnell <odonnelljp01@gmail.com>
Cc: pgsql-docs@postgresql.org
Subject: Re: Example error in createdb doc
Date: Tue, 22 Nov 2016 18:17:35 -0500
Message-ID: <16840.1479856655@sss.pgh.pa.us> (raw)
In-Reply-To: <20161122223144.GA31341@momjian.us>
References: <CAOYeSOdUxLryVKsNkKs3tXCGSdQi2H7Wr6kMCWLpPnhu-JO_qQ@mail.gmail.com>
<20161122223144.GA31341@momjian.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
Bruce Momjian <bruce@momjian.us> writes:
> On Thu, Oct 27, 2016 at 09:01:59PM -0400, Jason O'Donnell wrote:
>> The example given for createdb fails because template0 is not provided:
> I have looked over this report and patch, and it just doesn't feel
> right. The example is intending to show how to use common psql-like
> options to control createdb. Adding the encoding is nice, but then
> having to switch to template0 so the encoding setting works just seems
> beyond the scope of what we want do there.
> I think the attached patch is more focused.
I dunno. The use of -e seems pretty pointless for a call that is going to
yield a trivial CREATE DATABASE command. Besides, we already showed a
minimal example. If you think Jason's example is too complex, what about
just subbing in "-T template0" for "-E LATIN1"? That should work
regardless of other configuration.
Also, your change to the text loses the point that -e provokes printing
the underlying command. Admittedly, that was somewhat indirect in the way
it was phrased before, but now the concept is just gone entirely; that
doesn't feel like an improvement either.
Personally I thought Jason's patch was fine as-is.
regards, tom lane
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, odonnelljp01@gmail.com
Subject: Re: Example error in createdb doc
In-Reply-To: <16840.1479856655@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox