pg.ddx.io pgsql-docs@postgresql.org mailing list archivehelp / color / mirror / Atom feed
correct documentation in set role 3+ messages / 2 participants [nested] [flat]
* correct documentation in set role @ 2023-09-25 07:46 PG Doc comments form <noreply@postgresql.org> 2023-09-26 15:44 ` Re: correct documentation in set role Bruce Momjian <bruce@momjian.us> 0 siblings, 1 reply; 3+ messages in thread From: PG Doc comments form @ 2023-09-25 07:46 UTC (permalink / raw) To: pgsql-docs@lists.postgresql.org; +Cc: mortoozseydi@gmail.com The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/sql-set-role.html Description: it is good to mention that: The specified role_name must be a role that the current session user is a member of "and has SET True option on it." The second part missed in documentation for set role command. ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: correct documentation in set role 2023-09-25 07:46 correct documentation in set role PG Doc comments form <noreply@postgresql.org> @ 2023-09-26 15:44 ` Bruce Momjian <bruce@momjian.us> 2023-09-26 20:14 ` Re: correct documentation in set role Bruce Momjian <bruce@momjian.us> 0 siblings, 1 reply; 3+ messages in thread From: Bruce Momjian @ 2023-09-26 15:44 UTC (permalink / raw) To: mortoozseydi@gmail.com; pgsql-docs@lists.postgresql.org On Mon, Sep 25, 2023 at 07:46:18AM +0000, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/sql-set-role.html > Description: > > it is good to mention that: > The specified role_name must be a role that the current session user is a > member of "and has SET True option on it." > The second part missed in documentation for set role command. Good point. How is the attached patch? -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. Attachments: [text/x-diff] set_role.diff (563B, ../../ZRL8alby8rOrm3Tu@momjian.us/2-set_role.diff) download | inline diff: diff --git a/doc/src/sgml/ref/set_role.sgml b/doc/src/sgml/ref/set_role.sgml index 13bad1bf66..a2661945aa 100644 --- a/doc/src/sgml/ref/set_role.sgml +++ b/doc/src/sgml/ref/set_role.sgml @@ -42,7 +42,8 @@ RESET ROLE <para> The specified <replaceable class="parameter">role_name</replaceable> - must be a role that the current session user is a member of. + must be a role that the current session user is a member of and + is granted <literal>WITH SET TRUE</literal>. (If the session user is a superuser, any role can be selected.) </para> ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: correct documentation in set role 2023-09-25 07:46 correct documentation in set role PG Doc comments form <noreply@postgresql.org> 2023-09-26 15:44 ` Re: correct documentation in set role Bruce Momjian <bruce@momjian.us> @ 2023-09-26 20:14 ` Bruce Momjian <bruce@momjian.us> 0 siblings, 0 replies; 3+ messages in thread From: Bruce Momjian @ 2023-09-26 20:14 UTC (permalink / raw) To: mortoozseydi@gmail.com; pgsql-docs@lists.postgresql.org On Tue, Sep 26, 2023 at 11:44:42AM -0400, Bruce Momjian wrote: > On Mon, Sep 25, 2023 at 07:46:18AM +0000, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/16/sql-set-role.html > > Description: > > > > it is good to mention that: > > The specified role_name must be a role that the current session user is a > > member of "and has SET True option on it." > > The second part missed in documentation for set role command. > > Good point. How is the attached patch? > diff --git a/doc/src/sgml/ref/set_role.sgml b/doc/src/sgml/ref/set_role.sgml > index 13bad1bf66..a2661945aa 100644 > --- a/doc/src/sgml/ref/set_role.sgml > +++ b/doc/src/sgml/ref/set_role.sgml > @@ -42,7 +42,8 @@ RESET ROLE > > <para> > The specified <replaceable class="parameter">role_name</replaceable> > - must be a role that the current session user is a member of. > + must be a role that the current session user is a member of and > + is granted <literal>WITH SET TRUE</literal>. > (If the session user is a superuser, any role can be selected.) > </para> Someone is already working on this text addition from a post yesterday: https://www.postgresql.org/message-id/20230925220945.GB3172533%40nathanxps13 Please ignore my patch and I will be sure the patch at this URL gets committed. Thanks. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com Only you can decide what is important to you. ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-09-26 20:14 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-09-25 07:46 correct documentation in set role PG Doc comments form <noreply@postgresql.org> 2023-09-26 15:44 ` Bruce Momjian <bruce@momjian.us> 2023-09-26 20:14 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox