Re: Add minimal C example and SQL registration example for custom table access methods.

agora inbox for pgsql-docs@postgresql.org  
help / color / mirror / Atom feed

From: Tristen Raab <tristen.raab@highgo.ca>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: Add minimal C example and SQL registration example for custom table access methods.
Date: Fri, 26 Jan 2024 19:56:37 +0000
Message-ID: <170629899743.1131.10530730698967721601.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <170009090469.2631681.9401767800677948331.pgcf@coridan.postgresql.org>
References: <CAByiw+r+CS-ojBDP7Dm=9YeOLkZTXVnBmOe_ajK=en8C_zB3_g@mail.gmail.com>
	<170009090469.2631681.9401767800677948331.pgcf@coridan.postgresql.org>

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            tested, passed

Hello,

I've reviewed your patch and it applies correctly and the documentation builds without any error. The built documentation also looks good with no formatting errors. It's always great to see more examples when reading through documentation so I think this patch is a good addition.

thanks,

-----------------------
Tristen Raab
Highgo Software Canada
www.highgo.ca

view thread (15+ messages)  latest in thread

Message-ID: <170629899743.1131.10530730698967721601.pgcf@coridan.postgresql.org>
Permalink:  ../170629899743.1131.10530730698967721601.pgcf@coridan.postgresql.org/
Also on:    postgresql.org/message-id/170629899743.1131.10530730698967721601.pgcf@coridan.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: tristen.raab@highgo.ca, pgsql-hackers@lists.postgresql.org
  Subject: Re: Add minimal C example and SQL registration example for custom table access methods.
  In-Reply-To: <170629899743.1131.10530730698967721601.pgcf@coridan.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox