From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-docs@postgresql.org
Subject: Re: Cannot build docs on Ubuntu 10.04?
Date: Thu, 22 Mar 2012 00:12:51 -0400
Message-ID: <17355.1332389571@sss.pgh.pa.us> (raw)
In-Reply-To: <29895.1331734915@sss.pgh.pa.us>
References: <COL116-W9647A1E352CAF66550327A3590@phx.gbl>
<29895.1331734915@sss.pgh.pa.us>
I wrote:
> Maybe the Makefile should just error out if COLLATEINDEX isn't set,
> rather than trying a "fallback" value that configure has already
> determined isn't going to work.
I looked at this a bit closer, and figured out why the Makefile is
trying an apparently pointless case: the test implemented in configure
is wrong! In at least some installations of docbook, for instance the
ancient one I've got in captivity on my HPUX box, collateindex.pl is
provided in $(DOCBOOKSTYLE)/bin/, but *it is not marked executable*.
This causes AC_PATH_PROGS to not consider it valid. However, the docs
Makefile is coded to invoke the script via $(PERL) $(COLLATEINDEX),
which is presumably done precisely to be able to cope with
not-executable scripts.
So I think we should adjust the configure test to accept
$(DOCBOOKSTYLE)/bin/collateindex.pl if it is readable, whether or not it
is executable, and only use the Autoconf macro if we fall back to
searching PATH for collateindex.pl. Having done that, it should be safe
to simplify the Makefile to throw error if COLLATEINDEX isn't set.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: Cannot build docs on Ubuntu 10.04?
In-Reply-To: <17355.1332389571@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox