From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Lumby <johnlumby@hotmail.com>
Cc: pgsql-docs@postgresql.org
Subject: Re: Cannot build docs on Ubuntu 10.04?
Date: Wed, 14 Mar 2012 10:21:55 -0400
Message-ID: <29895.1331734915@sss.pgh.pa.us> (raw)
In-Reply-To: <COL116-W9647A1E352CAF66550327A3590@phx.gbl>
References: <COL116-W9647A1E352CAF66550327A3590@phx.gbl>
John Lumby <johnlumby@hotmail.com> writes:
> On 12-01-2012 17:28, Josh Berkus wrote:
> I wonder if everyone noticed that the postgres sgml makefile is looking for the script in /bin
> (see Josh's append)
That means that configure failed to find it, and failed to determine
a setting for DOCBOOKSTYLE as well.
> I think this line in
> postgresql-9.1.3/doc/src/sgml/Makefile
> COLLATEINDEX = $(DOCBOOKSTYLE)/bin/collateindex.pl
> could be improved - maybe should read
> COLLATEINDEX = `which collateindex.pl`
No, that would not be an improvement. If collateindex.pl were in your
PATH, then configure would have found it (cf PGAC_PATH_COLLATEINDEX),
and so COLLATEINDEX would be set and we'd not be here at all.
Maybe the Makefile should just error out if COLLATEINDEX isn't set,
rather than trying a "fallback" value that configure has already
determined isn't going to work.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, johnlumby@hotmail.com
Subject: Re: Cannot build docs on Ubuntu 10.04?
In-Reply-To: <29895.1331734915@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox