pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Pg Docs <pgsql-docs@lists.postgresql.org>
Subject: Re: Duplicating website's formatting in local doc builds
Date: Fri, 14 Feb 2020 20:51:39 -0500
Message-ID: <17445.1581731499@sss.pgh.pa.us> (raw)
In-Reply-To: <8d663c68-3df0-bf3f-8c2e-e6897a55394a@postgresql.org>
References: <1375.1581446233@sss.pgh.pa.us>
	<d381c45a-880f-7b0d-773d-be117685a6ad@postgresql.org>
	<3873.1581449531@sss.pgh.pa.us>
	<4b44c4ec-a678-6586-fbb0-efc3299af203@postgresql.org>
	<CAH2-Wzka_NfJGfL9UvQ1Jau1gqerat2zR9O0iAm3DgQEAYebJQ@mail.gmail.com>
	<dc3089b0-9c40-fc3b-bce1-7fcc16891dd1@postgresql.org>
	<86f03290-e60c-855e-786a-d1b75c254811@postgresql.org>
	<716a39ec-6f56-0280-8d4b-b246176c6a3d@postgresql.org>
	<bd7e5ec0-caa4-56d0-562e-21880e205e02@postgresql.org>
	<11007.1581721578@sss.pgh.pa.us>
	<8d663c68-3df0-bf3f-8c2e-e6897a55394a@postgresql.org>

"Jonathan S. Katz" <jkatz@postgresql.org> writes:
> A potential solution is that we drop the use of "monospace" in relying
> on the OS default and just pick a font. I would say that this is outside
> the scope of the patch that's being proposed, but certainly something to
> look into on the pgweb side given we're creating an inconsistent
> cross-browser experience.

Agreed, not in-scope for this patch.

>> The point about network access seems to me to be sufficient reason not
>> to make it the default.  I'd actually say that we ought to annotate
>> section J.3.1 to point out that "make STYLE=website" will result in
>> that.  However, I'm not quite clear on whether that means external
>> access during viewing, or during build, or both?  The note should say.

> It would only be during viewing -- the build just puts the URL into the
> HTML file.

OK.

> But don't take my word for it, please see the attached patch ;)

Hm, I wouldn't go into that much detail; it'd likely soon be out of
date anyway.  I had in mind something more like "If the STYLE=website
option is used, the generated HTML files will include references to
stylesheets hosted at www.postgresql.org, so that viewing them will
require network access."

			regards, tom lane





view thread (18+ messages)  latest in thread

Message-ID: <17445.1581731499@sss.pgh.pa.us>
Permalink:  ../17445.1581731499@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/17445.1581731499@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jkatz@postgresql.org, pg@bowt.ie, pgsql-docs@lists.postgresql.org
  Subject: Re: Duplicating website's formatting in local doc builds
  In-Reply-To: <17445.1581731499@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox