From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-docs@postgresql.org, PostgreSQL-patches <pgsql-patches@postgresql.org>
Subject: Re: Change draft gmake control
Date: Sat, 27 Jan 2007 17:47:01 -0500 (EST)
Message-ID: <200701272247.l0RMl1t13872@momjian.us> (raw)
In-Reply-To: <23143.1169932756@sss.pgh.pa.us>
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Well, if 'draft' was only for html, I could see suggesting just 'gmake
> > draft', but 'draft' can be used for Postscript and PDF too.
>
> But those aren't cases where saving some typing is useful (in fact,
> I'd bet money that no one will ever use them). Draft runs with html
> output are highly useful, and like Peter I think "make draft" ought
> to work for that.
OK, if that's what people want. Patch attached and applied, docs
updated.
--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Attachments:/rtmp/diff (text/x-diff, 1.4K) download
Index: sgml/Makefile
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/Makefile,v
retrieving revision 1.93
diff -c -r1.93 Makefile
*** sgml/Makefile 26 Jan 2007 23:51:39 -0000 1.93
--- sgml/Makefile 27 Jan 2007 22:33:17 -0000
***************
*** 99,104 ****
--- 99,110 ----
endif
+ # The draft rule calls gmake again and sets the DRAFT variable.+ # This seems to be the only way to set gmake variables in a rule.+ draft:+ @$(MAKE) DRAFT="Y" html+ +
COLLATEINDEX := LC_ALL=C $(PERL) $(COLLATEINDEX) -f -g
# bookindex.sgml is required so there is a proper index for all output formats
Index: sgml/docguide.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/docguide.sgml,v
retrieving revision 1.66
diff -c -r1.66 docguide.sgml
*** sgml/docguide.sgml 26 Jan 2007 22:23:50 -0000 1.66
--- sgml/docguide.sgml 27 Jan 2007 22:33:17 -0000
***************
*** 546,552 ****
stages. If you do not care about the index, and just want to
proof-read the output, use <literal>draft</>:
<screen>
! <prompt>doc/src/sgml$ </prompt><userinput>gmake DRAFT=Y html</userinput>
</screen>
</para>
--- 546,552 ----
stages. If you do not care about the index, and just want to
proof-read the output, use <literal>draft</>:
<screen>
! <prompt>doc/src/sgml$ </prompt><userinput>gmake draft</userinput>
</screen>
</para>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, peter_e@gmx.net, pgsql-patches@postgresql.org
Subject: Re: Change draft gmake control
In-Reply-To: <200701272247.l0RMl1t13872@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox