public inbox for [email protected]help / color / mirror / Atom feed
Fix misleading references to columns in GRANT/REVOKE summaries 10+ messages / 5 participants [nested] [flat]
* Fix misleading references to columns in GRANT/REVOKE summaries @ 2007-04-06 23:46 David Fetter <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: David Fetter @ 2007-04-06 23:46 UTC (permalink / raw) To: pgsql-docs; PostgreSQL Patches <[email protected]> Folks, Per a question Alexey Parshin asked in the IRC channel, I'm attaching a patch to the GRANT and REVOKE syntax summaries which replaces the misleading word "column" with "parameter." "Column" is misleading because it could be read to imply a column-level GRANT/REVOKE, which we don't have yet. Cheers, D -- David Fetter <[email protected]> http://fetter.org/ phone: +1 415 235 3778 AIM: dfetter666 Skype: davidfetter Remember to vote! Consider donating to PostgreSQL: http://www.postgresql.org/about/donate Index: doc/src/sgml/ref/grant.sgml =================================================================== RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/grant.sgml,v retrieving revision 1.64 diff -c -r1.64 grant.sgml *** doc/src/sgml/ref/grant.sgml 1 Feb 2007 00:28:19 -0000 1.64 --- doc/src/sgml/ref/grant.sgml 6 Apr 2007 23:39:20 -0000 *************** *** 525,531 **** <synopsis> GRANT <replaceable class="PARAMETER">privileges</replaceable> ! ON <replaceable class="PARAMETER">table</replaceable> [ ( <replaceable class="PARAMETER">column</replaceable> [, ...] ) ] [, ...] TO { PUBLIC | <replaceable class="PARAMETER">username</replaceable> [, ...] } [ WITH GRANT OPTION ] </synopsis> </para> --- 525,532 ---- <synopsis> GRANT <replaceable class="PARAMETER">privileges</replaceable> ! ON <replaceable class="PARAMETER">table</replaceable> [ ( ! <replaceable class="PARAMETER">parameter</replaceable> [, ...] ) ] [, ...] TO { PUBLIC | <replaceable class="PARAMETER">username</replaceable> [, ...] } [ WITH GRANT OPTION ] </synopsis> </para> Index: doc/src/sgml/ref/revoke.sgml =================================================================== RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/revoke.sgml,v retrieving revision 1.42 diff -c -r1.42 revoke.sgml *** doc/src/sgml/ref/revoke.sgml 31 Jan 2007 23:26:04 -0000 1.42 --- doc/src/sgml/ref/revoke.sgml 6 Apr 2007 23:39:20 -0000 *************** *** 235,241 **** <synopsis> REVOKE [ GRANT OPTION FOR ] <replaceable class="PARAMETER">privileges</replaceable> ! ON <replaceable class="parameter">object</replaceable> [ ( <replaceable class="parameter">column</replaceable> [, ...] ) ] FROM { PUBLIC | <replaceable class="parameter">username</replaceable> [, ...] } { RESTRICT | CASCADE } </synopsis> --- 235,242 ---- <synopsis> REVOKE [ GRANT OPTION FOR ] <replaceable class="PARAMETER">privileges</replaceable> ! ON <replaceable class="parameter">object</replaceable> [ ( ! <replaceable class="parameter">parameter</replaceable> [, ...] ) ] FROM { PUBLIC | <replaceable class="parameter">username</replaceable> [, ...] } { RESTRICT | CASCADE } </synopsis> Attachments: [text/plain] fix_grant_revoke.diff (2.2K, 2-fix_grant_revoke.diff) download | inline diff: Index: doc/src/sgml/ref/grant.sgml =================================================================== RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/grant.sgml,v retrieving revision 1.64 diff -c -r1.64 grant.sgml *** doc/src/sgml/ref/grant.sgml 1 Feb 2007 00:28:19 -0000 1.64 --- doc/src/sgml/ref/grant.sgml 6 Apr 2007 23:39:20 -0000 *************** *** 525,531 **** <synopsis> GRANT <replaceable class="PARAMETER">privileges</replaceable> ! ON <replaceable class="PARAMETER">table</replaceable> [ ( <replaceable class="PARAMETER">column</replaceable> [, ...] ) ] [, ...] TO { PUBLIC | <replaceable class="PARAMETER">username</replaceable> [, ...] } [ WITH GRANT OPTION ] </synopsis> </para> --- 525,532 ---- <synopsis> GRANT <replaceable class="PARAMETER">privileges</replaceable> ! ON <replaceable class="PARAMETER">table</replaceable> [ ( ! <replaceable class="PARAMETER">parameter</replaceable> [, ...] ) ] [, ...] TO { PUBLIC | <replaceable class="PARAMETER">username</replaceable> [, ...] } [ WITH GRANT OPTION ] </synopsis> </para> Index: doc/src/sgml/ref/revoke.sgml =================================================================== RCS file: /projects/cvsroot/pgsql/doc/src/sgml/ref/revoke.sgml,v retrieving revision 1.42 diff -c -r1.42 revoke.sgml *** doc/src/sgml/ref/revoke.sgml 31 Jan 2007 23:26:04 -0000 1.42 --- doc/src/sgml/ref/revoke.sgml 6 Apr 2007 23:39:20 -0000 *************** *** 235,241 **** <synopsis> REVOKE [ GRANT OPTION FOR ] <replaceable class="PARAMETER">privileges</replaceable> ! ON <replaceable class="parameter">object</replaceable> [ ( <replaceable class="parameter">column</replaceable> [, ...] ) ] FROM { PUBLIC | <replaceable class="parameter">username</replaceable> [, ...] } { RESTRICT | CASCADE } </synopsis> --- 235,242 ---- <synopsis> REVOKE [ GRANT OPTION FOR ] <replaceable class="PARAMETER">privileges</replaceable> ! ON <replaceable class="parameter">object</replaceable> [ ( ! <replaceable class="parameter">parameter</replaceable> [, ...] ) ] FROM { PUBLIC | <replaceable class="parameter">username</replaceable> [, ...] } { RESTRICT | CASCADE } </synopsis> ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: Fix misleading references to columns in GRANT/REVOKE summaries @ 2007-04-07 01:06 Tom Lane <[email protected]> parent: David Fetter <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Tom Lane @ 2007-04-07 01:06 UTC (permalink / raw) To: David Fetter <[email protected]>; +Cc: pgsql-docs; PostgreSQL Patches <[email protected]> David Fetter <[email protected]> writes: > Per a question Alexey Parshin asked in the IRC channel, I'm attaching > a patch to the GRANT and REVOKE syntax summaries which replaces the > misleading word "column" with "parameter." "Column" is misleading > because it could be read to imply a column-level GRANT/REVOKE, which > we don't have yet. Apparently it's so misleading that you didn't understand it either. The entire *point* of that paragraph is that we don't have the feature. This proposed change is surely not an improvement... regards, tom lane ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [DOCS] Fix misleading references to columns in GRANT/REVOKE summaries @ 2007-04-07 01:53 Russell Smith <[email protected]> parent: Tom Lane <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Russell Smith @ 2007-04-07 01:53 UTC (permalink / raw) To: Tom Lane <[email protected]>; +Cc: David Fetter <[email protected]>; pgsql-docs; PostgreSQL Patches <[email protected]> Tom Lane wrote: > David Fetter <[email protected]> writes: > >> Per a question Alexey Parshin asked in the IRC channel, I'm attaching >> a patch to the GRANT and REVOKE syntax summaries which replaces the >> misleading word "column" with "parameter." "Column" is misleading >> because it could be read to imply a column-level GRANT/REVOKE, which >> we don't have yet. >> > > Apparently it's so misleading that you didn't understand it either. > The entire *point* of that paragraph is that we don't have the > feature. This proposed change is surely not an improvement... > Maybe removing the entire example would be more helpful. I don't find it clear to have a command outline in a compatibility block. > regards, tom lane > > ---------------------------(end of broadcast)--------------------------- > TIP 9: In versions below 8.0, the planner will ignore your desire to > choose an index scan if your joining column's datatypes do not > match > > ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [PATCHES] Fix misleading references to columns in GRANT/REVOKE summaries @ 2007-04-07 02:24 Tom Lane <[email protected]> parent: Russell Smith <[email protected]> 0 siblings, 2 replies; 10+ messages in thread From: Tom Lane @ 2007-04-07 02:24 UTC (permalink / raw) To: Russell Smith <[email protected]>; +Cc: David Fetter <[email protected]>; pgsql-docs; PostgreSQL Patches <[email protected]> Russell Smith <[email protected]> writes: > Tom Lane wrote: >> The entire *point* of that paragraph is that we don't have the >> feature. This proposed change is surely not an improvement... >> > Maybe removing the entire example would be more helpful. I don't find > it clear to have a command outline in a compatibility block. True, there doesn't seem to be any point in providing a full syntax summary rather than just saying "the SQL spec says you can grant privileges on columns but we don't support that yet". regards, tom lane ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [PATCHES] Fix misleading references to columns in GRANT/REVOKE summaries @ 2007-04-07 03:49 Bruce Momjian <[email protected]> parent: Tom Lane <[email protected]> 1 sibling, 1 reply; 10+ messages in thread From: Bruce Momjian @ 2007-04-07 03:49 UTC (permalink / raw) To: Tom Lane <[email protected]>; +Cc: Russell Smith <[email protected]>; David Fetter <[email protected]>; pgsql-docs; PostgreSQL Patches <[email protected]> Tom Lane wrote: > Russell Smith <[email protected]> writes: > > Tom Lane wrote: > >> The entire *point* of that paragraph is that we don't have the > >> feature. This proposed change is surely not an improvement... > >> > > Maybe removing the entire example would be more helpful. I don't find > > it clear to have a command outline in a compatibility block. > > True, there doesn't seem to be any point in providing a full syntax > summary rather than just saying "the SQL spec says you can grant > privileges on columns but we don't support that yet". Agreed. Patch attached and applied. I don't see any other cases of this in our documentation. -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + Attachments: [text/x-diff] /rtmp/diff (2.5K, 2-%2Frtmp%2Fdiff) download | inline diff: Index: doc/src/sgml/ref/grant.sgml =================================================================== RCS file: /cvsroot/pgsql/doc/src/sgml/ref/grant.sgml,v retrieving revision 1.64 diff -c -c -r1.64 grant.sgml *** doc/src/sgml/ref/grant.sgml 1 Feb 2007 00:28:19 -0000 1.64 --- doc/src/sgml/ref/grant.sgml 7 Apr 2007 03:45:36 -0000 *************** *** 520,533 **** </para> <para> ! The SQL standard allows setting privileges for individual columns ! within a table: ! ! <synopsis> ! GRANT <replaceable class="PARAMETER">privileges</replaceable> ! ON <replaceable class="PARAMETER">table</replaceable> [ ( <replaceable class="PARAMETER">column</replaceable> [, ...] ) ] [, ...] ! TO { PUBLIC | <replaceable class="PARAMETER">username</replaceable> [, ...] } [ WITH GRANT OPTION ] ! </synopsis> </para> <para> --- 520,527 ---- </para> <para> ! <productname>PostgreSQL</productname> does not support the SQL-standard ! functionality of setting privileges for individual columns. </para> <para> Index: doc/src/sgml/ref/revoke.sgml =================================================================== RCS file: /cvsroot/pgsql/doc/src/sgml/ref/revoke.sgml,v retrieving revision 1.42 diff -c -c -r1.42 revoke.sgml *** doc/src/sgml/ref/revoke.sgml 31 Jan 2007 23:26:04 -0000 1.42 --- doc/src/sgml/ref/revoke.sgml 7 Apr 2007 03:45:37 -0000 *************** *** 231,245 **** <para> The compatibility notes of the <xref linkend="sql-grant" endterm="sql-grant-title"> command ! apply analogously to <command>REVOKE</command>. The syntax summary is: ! ! <synopsis> ! REVOKE [ GRANT OPTION FOR ] <replaceable class="PARAMETER">privileges</replaceable> ! ON <replaceable class="parameter">object</replaceable> [ ( <replaceable class="parameter">column</replaceable> [, ...] ) ] ! FROM { PUBLIC | <replaceable class="parameter">username</replaceable> [, ...] } ! { RESTRICT | CASCADE } ! </synopsis> ! One of <literal>RESTRICT</literal> or <literal>CASCADE</literal> is required according to the standard, but <productname>PostgreSQL</> assumes <literal>RESTRICT</literal> by default. </para> --- 231,238 ---- <para> The compatibility notes of the <xref linkend="sql-grant" endterm="sql-grant-title"> command ! apply analogously to <command>REVOKE</command>. ! <literal>RESTRICT</literal> or <literal>CASCADE</literal> is required according to the standard, but <productname>PostgreSQL</> assumes <literal>RESTRICT</literal> by default. </para> ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [PATCHES] Fix misleading references to columns in GRANT/REVOKE summaries @ 2007-04-08 19:34 Peter Eisentraut <[email protected]> parent: Tom Lane <[email protected]> 1 sibling, 0 replies; 10+ messages in thread From: Peter Eisentraut @ 2007-04-08 19:34 UTC (permalink / raw) To: pgsql-docs; +Cc: Tom Lane <[email protected]>; Russell Smith <[email protected]>; David Fetter <[email protected]>; PostgreSQL Patches <[email protected]> Tom Lane wrote: > True, there doesn't seem to be any point in providing a full syntax > summary rather than just saying "the SQL spec says you can grant > privileges on columns but we don't support that yet". I think it's pretty useful if people see a command of this form from some other implementation and don't know what it means. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [PATCHES] Fix misleading references to columns in GRANT/REVOKE summaries @ 2007-04-08 19:36 Peter Eisentraut <[email protected]> parent: Bruce Momjian <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Peter Eisentraut @ 2007-04-08 19:36 UTC (permalink / raw) To: [email protected]; +Cc: Bruce Momjian <[email protected]>; Tom Lane <[email protected]>; Russell Smith <[email protected]>; David Fetter <[email protected]>; pgsql-docs Bruce Momjian wrote: > > True, there doesn't seem to be any point in providing a full syntax > > summary rather than just saying "the SQL spec says you can grant > > privileges on columns but we don't support that yet". > > Agreed. Patch attached and applied. I don't see any other cases of > this in our documentation. That doesn't mean this one isn't useful. Please revert this. -- Peter Eisentraut http://developer.postgresql.org/~petere/ ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [PATCHES] Fix misleading references to columns in GRANT/REVOKE summaries @ 2007-04-09 01:46 Bruce Momjian <[email protected]> parent: Peter Eisentraut <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Bruce Momjian @ 2007-04-09 01:46 UTC (permalink / raw) To: Peter Eisentraut <[email protected]>; +Cc: [email protected]; Tom Lane <[email protected]>; Russell Smith <[email protected]>; David Fetter <[email protected]>; pgsql-docs Peter Eisentraut wrote: > Bruce Momjian wrote: > > > True, there doesn't seem to be any point in providing a full syntax > > > summary rather than just saying "the SQL spec says you can grant > > > privileges on columns but we don't support that yet". > > > > Agreed. Patch attached and applied. I don't see any other cases of > > this in our documentation. > > That doesn't mean this one isn't useful. Please revert this. Well, Tom and I thought it caused confusion, as did the person reporting the confusion. You saying to revert it isn't enough. -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [PATCHES] Fix misleading references to columns in GRANT/REVOKE summaries @ 2007-04-09 02:28 Tom Lane <[email protected]> parent: Bruce Momjian <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Tom Lane @ 2007-04-09 02:28 UTC (permalink / raw) To: Bruce Momjian <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; [email protected]; Russell Smith <[email protected]>; David Fetter <[email protected]>; pgsql-docs Bruce Momjian <[email protected]> writes: > Peter Eisentraut wrote: >> That doesn't mean this one isn't useful. Please revert this. > Well, Tom and I thought it caused confusion, as did the person reporting > the confusion. You saying to revert it isn't enough. A possible compromise is to describe or show the syntax in some informal form, so that it didn't look like one of the <synopsis> sections we use for supported syntax. I'm not sure what that would look like exactly, but I do see merit in both sides of this discussion... regards, tom lane ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [PATCHES] Fix misleading references to columns in GRANT/REVOKE summaries @ 2007-04-09 02:52 Bruce Momjian <[email protected]> parent: Tom Lane <[email protected]> 0 siblings, 0 replies; 10+ messages in thread From: Bruce Momjian @ 2007-04-09 02:52 UTC (permalink / raw) To: Tom Lane <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; [email protected]; Russell Smith <[email protected]>; David Fetter <[email protected]>; pgsql-docs Tom Lane wrote: > Bruce Momjian <[email protected]> writes: > > Peter Eisentraut wrote: > >> That doesn't mean this one isn't useful. Please revert this. > > > Well, Tom and I thought it caused confusion, as did the person reporting > > the confusion. You saying to revert it isn't enough. > > A possible compromise is to describe or show the syntax in some informal > form, so that it didn't look like one of the <synopsis> sections we use > for supported syntax. I'm not sure what that would look like exactly, > but I do see merit in both sides of this discussion... I am all for us describing how we don't match the SQL spec, but just showing the syntax doesn't seem to help people understand how we don't match the spec, does it? Are there more details to column-level GRANT except saying we don't support it? -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ^ permalink raw reply [nested|flat] 10+ messages in thread
end of thread, other threads:[~2007-04-09 02:52 UTC | newest] Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2007-04-06 23:46 Fix misleading references to columns in GRANT/REVOKE summaries David Fetter <[email protected]> 2007-04-07 01:06 ` Tom Lane <[email protected]> 2007-04-07 01:53 ` Russell Smith <[email protected]> 2007-04-07 02:24 ` Tom Lane <[email protected]> 2007-04-07 03:49 ` Bruce Momjian <[email protected]> 2007-04-08 19:36 ` Peter Eisentraut <[email protected]> 2007-04-09 01:46 ` Bruce Momjian <[email protected]> 2007-04-09 02:28 ` Tom Lane <[email protected]> 2007-04-09 02:52 ` Bruce Momjian <[email protected]> 2007-04-08 19:34 ` Peter Eisentraut <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox