From: Magnus Hagander <magnus@hagander.net>
To: Gregory Stark <stark@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Oleg Bartunov <oleg@sai.msu.su>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: tsearch filenames unlikes special symbols and numbers
Date: Mon, 3 Sep 2007 09:56:09 +0200
Message-ID: <20070903075609.GD21833@svr2.hagander.net> (raw)
In-Reply-To: <87tzqci6tp.fsf@oxford.xeocode.com>
References: <162867790709021328i7771aa9jfe79268bccbf123d@mail.gmail.com>
<Pine.LNX.4.64.0709030113090.2767@sn.sai.msu.ru>
<18259.1188773171@sss.pgh.pa.us>
<87y7foir7t.fsf@oxford.xeocode.com>
<19257.1188777110@sss.pgh.pa.us>
<87tzqci6tp.fsf@oxford.xeocode.com>
On Mon, Sep 03, 2007 at 07:47:14AM +0100, Gregory Stark wrote:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
>
> > Gregory Stark <stark@enterprisedb.com> writes:
> >> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
> >>> I made it reject all but latin letters, which is the same restriction
> >>> that's in place for timezone set filenames. That might be overly
> >>> strong, but we definitely have to forbid "." and "/" (and "\" on
> >>> Windows). Do we want to restrict it to letters, digits, underscore?
> >>> Or does it need to be weaker than that?
> >
> >> What's the problem with "."?
> >
> > ../../../../etc/passwd
> >
> > Possibly we could allow '.' as long as we forbade /,
>
> Right, traditionally the only characters forbidden in filenames in Unix are /
> and nul. If we want the files to play nice in Gnome etc then we should
> restrict them to ascii since we don't know what encoding the gui expects.
>
> Actually I think in Windows \ : and . are problems (not allowed more than one
> dot in dos).
\ and : are problems.
. is not a problem. We don't support 16-bit windows anyway, and multiple
dots works fine on any system we support.
//Magnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: magnus@hagander.net, stark@enterprisedb.com, tgl@sss.pgh.pa.us, oleg@sai.msu.su, pavel.stehule@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: tsearch filenames unlikes special symbols and numbers
In-Reply-To: <20070903075609.GD21833@svr2.hagander.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox