public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bruce Momjian <[email protected]>
To: Simon Riggs <[email protected]>
Cc: pgsql-docs <[email protected]>
Subject: Re: Incorrect description of xmax and xip in functions docs
Date: Sun, 7 Sep 2008 08:31:48 -0400 (EDT)
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

Simon Riggs wrote:
> 
> On Sat, 2008-09-06 at 21:31 -0400, Bruce Momjian wrote:
> > Applied, and attached.
> 
> Thanks.
> 
> > > And for txid_visible_in_snapshot() comment added:
> > > "Function should not be used with subtransaction xids. It is possible
> > > that this function will return a true result for a subtransaction xid
> > > that was actually still in progress at the time of the snapshot".
> > 
> > I think the cleaner solution is to throw an appropriate error if a
> > subtransaction xid is used, rather than adding documentation.
> 
> Or maybe check subtrans for it, as it really should be doing.

Yea, that's what I meant.  You can't be sure everyone is going to read
the documentation but they are sure to see the function results or error
message.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Incorrect description of xmax and xip in functions docs
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox