public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bruce Momjian <[email protected]>
To: David Johnston <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?
Date: Wed, 10 Sep 2014 16:20:02 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKFQuwbn=wB_rgkJQRvUH+KOGUUPU9Hde3b0cZvSAv=62df95w@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CAKFQuwbjqT7jHAULPM0YB7x=+qpddH5bYnGmwZ+yVhNBb6SVnQ@mail.gmail.com>
<CAKFQuwa5d3EUBGwYN1mA6FKO1K7kO+Wci8yM57QNHdEGQ9TJ9g@mail.gmail.com>
<CAKFQuwbbOZRqmnx-XRyd+viT+MCAH6TVc0yn1aJtG5MdSNAWpA@mail.gmail.com>
<[email protected]>
<CAKFQuwbn=wB_rgkJQRvUH+KOGUUPU9Hde3b0cZvSAv=62df95w@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-docs>
On Tue, Sep 9, 2014 at 03:40:45PM -0400, David Johnston wrote:
> Minor corrections:
>
> First block: "
> In the first section of this chapter, we
> describe how to set configuration parameters"
>
> - remove the comma
>
> Second Block:
> - placement of the colon inside or outside of the emphasis tag is inconsistent
> (string, unit, enum are inside; boolean and numeric are outside)
> - units: "An numeric value..." -> maybe "An unadorned numeric value...
>
> Third block:
> "Hash marks (<literal>#</literal>) designate the remainder of lines as
> comments." -> "...designate the remainder of the line as a comment." I read
> this at first as "remaining lines [in the file] ... "
>
> "To embed a single quote in a parameter value, write either two quotes
> (preferred) or backslash-quote." -> remove the comma
> "Querying this view is the sames as" -> "the same as"
I agree all of the above are improvements, and changed.
> "In addition to setting global defaults or attaching" <- add a comma after
> "defaults"
I didn't like this change as it causes too many comma phrases.
Attaches are the changes since yesterday's patch. The full patch is at:
ftp://momjian.us/postgresql/mypatches/config.diff
--
Bruce Momjian <[email protected]> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
--
Sent via pgsql-docs mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Attachments:
[text/x-diff] change.diff (4.7K, 2-change.diff)
download | inline diff:
commit 01cbe3a4949664f3b001a7d3be7990d37fc8a291
Author: Bruce Momjian <[email protected]>
Date: Wed Sep 10 15:49:06 2014 -0400
dummy commit
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
new file mode 100644
index 156c264..4a97855
*** a/doc/src/sgml/config.sgml
--- b/doc/src/sgml/config.sgml
***************
*** 10,16 ****
<para>
There are many configuration parameters that affect the behavior of
! the database system. In the first section of this chapter, we
describe how to interact with configuration parameters. The subsequent sections
discuss each parameter in detail.
</para>
--- 10,16 ----
<para>
There are many configuration parameters that affect the behavior of
! the database system. In the first section of this chapter we
describe how to interact with configuration parameters. The subsequent sections
discuss each parameter in detail.
</para>
***************
*** 31,37 ****
<listitem>
<para>
! <emphasis>Boolean</emphasis>: Values can be written as
<literal>on</literal>,
<literal>off</literal>,
<literal>true</literal>,
--- 31,37 ----
<listitem>
<para>
! <emphasis>Boolean:</emphasis> Values can be written as
<literal>on</literal>,
<literal>off</literal>,
<literal>true</literal>,
***************
*** 54,61 ****
<listitem>
<para>
! <emphasis>Numeric</emphasis> (integer and floating point): Do not use
! single-quotes (unless otherwise required) or thousand separators.
</para>
</listitem>
--- 54,62 ----
<listitem>
<para>
! <emphasis>Numeric (integer and floating point):</emphasis> Do
! not use single-quotes (unless otherwise required) or thousand
! separators.
</para>
</listitem>
***************
*** 64,71 ****
<emphasis>Numeric or String with Unit (Memory &
Time):</emphasis> These have an implicit unit, which is
either kilobytes, blocks (typically eight kilobytes),
! milliseconds, seconds, or minutes. An numeric value
! will use the default, which can be found by referencing
<structname>pg_settings</>.<structfield>unit</>. For convenience,
a different unit can also be specified explicitly via a string
value. It is case-sensitive and may include whitespace between
--- 65,72 ----
<emphasis>Numeric or String with Unit (Memory &
Time):</emphasis> These have an implicit unit, which is
either kilobytes, blocks (typically eight kilobytes),
! milliseconds, seconds, or minutes. A unadorned numeric
! value will use the default, which can be found by referencing
<structname>pg_settings</>.<structfield>unit</>. For convenience,
a different unit can also be specified explicitly via a string
value. It is case-sensitive and may include whitespace between
*************** log_destination = 'syslog'
*** 123,134 ****
search_path = '"$user", public'
shared_buffers = 128MB
</programlisting>
! One parameter is specified per line. The equal sign between name
! and value is optional. Whitespace is insignificant and blank
! lines are ignored. Hash marks (<literal>#</literal>) designate the
! remainder of lines as comments. Parameter values that are not simple
identifiers or numbers must be single-quoted. To embed a single
! quote in a parameter value, write either two quotes (preferred)
or backslash-quote.
</para>
--- 124,135 ----
search_path = '"$user", public'
shared_buffers = 128MB
</programlisting>
! One parameter is specified per line. The equal sign between name and
! value is optional. Whitespace is insignificant and blank lines are
! ignored. Hash marks (<literal>#</literal>) designate the remainder
! of the line as a comment. Parameter values that are not simple
identifiers or numbers must be single-quoted. To embed a single
! quote in a parameter value write either two quotes (preferred)
or backslash-quote.
</para>
*************** shared_buffers = 128MB
*** 229,235 ****
<itemizedlist>
<listitem>
<para>
! Querying this view is the sames as <command>SHOW</> but provides
more detail, as well as allowing for joins against other relations
and the specification of filter criteria.
</para>
--- 230,236 ----
<itemizedlist>
<listitem>
<para>
! Querying this view is the same as <command>SHOW</> but provides
more detail, as well as allowing for joins against other relations
and the specification of filter criteria.
</para>
view thread (9+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [9.3] Should we mention "set_config(...)" in 18.1.3 in Server Configuration?
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox