From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL-documentation <pgsql-docs@postgresql.org>
Subject: Re: pg_xlogdump -p option correction
Date: Sat, 7 Jan 2017 11:20:59 -0500
Message-ID: <20170107162059.GE3164@momjian.us> (raw)
In-Reply-To: <CAB7nPqRAFVTuJOPivPwGXH_P+7gXWT6wZg2UTE28Uo8mRciUBQ@mail.gmail.com>
References: <20161226215604.GA24784@momjian.us>
<CAB7nPqTW2iH70tJkhu8U9AUmVKB43gR0FvODmctqS=+fjuuzhA@mail.gmail.com>
<20170107010257.GB3164@momjian.us>
<CAB7nPqRAFVTuJOPivPwGXH_P+7gXWT6wZg2UTE28Uo8mRciUBQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
On Sat, Jan 7, 2017 at 09:50:32PM +0900, Michael Paquier wrote:
> >> 2) The documentation does not mention that if a directory is defined
> >> pg_xlogdump will try to look as well at defined_dir/pg_wal.
> >
> > Uh, I think it does in the first sentence:
> >
> > Directory in which to find log segment files.
>
> I am reading that as "only the current directory", not "the current
> directory, then current directory + pg_wal". Do you think that this
> sentence implies that the check routine looks as well at
> current_dir/pg_wal?
>
> > Updated patch attached.
>
> + subdirectory of both the current directory and the
> + <envar>PGDATA</envar> directory.
> This could say "of both the current directory and *then* the PGDATA
> directory" to outline the order of the actions taken by the check
> routine. Just my 2c on the matter.
Ah, I see your point. I ended up rewording the text to be more explicit
about the supplied argument and "searching". Updated patch attached.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docsAttachments:xlogdump.diff (text/x-diff, 2.5K) downloaddiff --git a/doc/src/sgml/ref/pg_xlogdump.sgml b/doc/src/sgml/ref/pg_xlogdump.sgmlnew file mode 100644index cfb6d87..4b6e79c
*** a/doc/src/sgml/ref/pg_xlogdump.sgml
--- b/doc/src/sgml/ref/pg_xlogdump.sgml
*************** PostgreSQL documentation
*** 117,125 ****
<term><option>--path=<replaceable>path</replaceable></option></term>
<listitem>
<para>
! Directory in which to find log segment files. The default is to search
! for them in the <literal>pg_wal</literal> subdirectory of the current
! directory.
</para>
</listitem>
</varlistentry>
--- 117,126 ----
<term><option>--path=<replaceable>path</replaceable></option></term>
<listitem>
<para>
! Specifies a directory in which to find log segment files.
! In addition, searches are performed in the current directory,
! and the <literal>pg_wal</literal> subdirectory of both the current
! directory and the <envar>PGDATA</envar> directory.
</para>
</listitem>
</varlistentry>
diff --git a/src/bin/pg_xlogdump/pg_xlogdump.c b/src/bin/pg_xlogdump/pg_xlogdump.cnew file mode 100644index 0ad441e..e83233f
*** a/src/bin/pg_xlogdump/pg_xlogdump.c
--- b/src/bin/pg_xlogdump/pg_xlogdump.c
*************** usage(void)
*** 680,686 ****
printf(_(" -f, --follow keep retrying after reaching end of WAL\n"));
printf(_(" -n, --limit=N number of records to display\n"));
printf(_(" -p, --path=PATH directory in which to find log segment files\n"
! " (default: ./pg_wal)\n"));
printf(_(" -r, --rmgr=RMGR only show records generated by resource manager RMGR\n"
" use --rmgr=list to list valid resource manager names\n"));
printf(_(" -s, --start=RECPTR start reading at log position RECPTR\n"));
--- 680,686 ----
printf(_(" -f, --follow keep retrying after reaching end of WAL\n"));
printf(_(" -n, --limit=N number of records to display\n"));
printf(_(" -p, --path=PATH directory in which to find log segment files\n"
! " (default: current directory, ./pg_wal, PGDATA/pg_wal)\n"));
printf(_(" -r, --rmgr=RMGR only show records generated by resource manager RMGR\n"
" use --rmgr=list to list valid resource manager names\n"));
printf(_(" -s, --start=RECPTR start reading at log position RECPTR\n"));
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, michael.paquier@gmail.com
Subject: Re: pg_xlogdump -p option correction
In-Reply-To: <20170107162059.GE3164@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox