From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL-documentation <pgsql-docs@postgresql.org>
Subject: Re: pg_xlogdump -p option correction
Date: Tue, 10 Jan 2017 22:38:53 -0500
Message-ID: <20170111033853.GA8584@momjian.us> (raw)
In-Reply-To: <CAB7nPqThD73UUSwOfpGdk0k36XmNGea9jLss02fbyHf7KWcSzw@mail.gmail.com>
References: <20161226215604.GA24784@momjian.us>
<CAB7nPqTW2iH70tJkhu8U9AUmVKB43gR0FvODmctqS=+fjuuzhA@mail.gmail.com>
<20170107010257.GB3164@momjian.us>
<CAB7nPqRAFVTuJOPivPwGXH_P+7gXWT6wZg2UTE28Uo8mRciUBQ@mail.gmail.com>
<20170107162059.GE3164@momjian.us>
<CAB7nPqRxDcgzuw3GMm2ys1wH+emPvN7fF5h=ND04Y0hu+ginbw@mail.gmail.com>
<20170109193223.GA19680@momjian.us>
<CAB7nPqThD73UUSwOfpGdk0k36XmNGea9jLss02fbyHf7KWcSzw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-docs>
On Tue, Jan 10, 2017 at 07:22:17AM +0900, Michael Paquier wrote:
> On Tue, Jan 10, 2017 at 4:32 AM, Bruce Momjian <bruce@momjian.us> wrote:
> > On Sun, Jan 8, 2017 at 03:27:59PM +0900, Michael Paquier wrote:
> >> >> + subdirectory of both the current directory and the
> >> >> + <envar>PGDATA</envar> directory.
> >> >> This could say "of both the current directory and *then* the PGDATA
> >> >> directory" to outline the order of the actions taken by the check
> >> >> routine. Just my 2c on the matter.
> >> >
> >> > Ah, I see your point. I ended up rewording the text to be more explicit
> >> > about the supplied argument and "searching". Updated patch attached.
> >>
> >> - Directory in which to find log segment files. The default is to search
> >> - for them in the <literal>pg_wal</literal> subdirectory of the current
> >> - directory.
> >> + Specifies a directory in which to find log segment files.
> >> + In addition, searches are performed in the current directory,
> >> + and the <literal>pg_wal</literal> subdirectory of both the current
> >> + directory and the <envar>PGDATA</envar> directory.
> >> Hm. This still misses the point that the lookup at PGDATA is done only
> >> if no directory is defined. What do you think about the patch attached
> >> that lists the five possible patterns: 2 for the case where a
> >> directory is defined, and 3 for the default case.
> >
> > Understood. Here is an updated patch which incorporates your
> > suggestions.
>
> Thanks. This looks good to me.
Slightly modified version applied and backpatched to 9.6 (use pg_xlog).
Thanks for your help.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, michael.paquier@gmail.com
Subject: Re: pg_xlogdump -p option correction
In-Reply-To: <20170111033853.GA8584@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox