public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Paquier <[email protected]>
To: Stephen Frost <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: Missing column_constraint explanation
Date: Sun, 14 Jan 2018 17:00:01 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAB7nPqRgrAuqT-xeEZqtmaT7SToKQrE3Vd+yxigd0xtiy88x9Q@mail.gmail.com>
	<[email protected]>
	<CAB7nPqTagNTV5LbKz3Jekrd2DkxoaER+7sPKPSmjkd-aY1foeQ@mail.gmail.com>
	<[email protected]>

On Sat, Jan 13, 2018 at 09:06:22PM -0500, Stephen Frost wrote:
> I'm not really sure that we want to go there for this case though.
> Perhaps others disagree, but that seems like a lot to avoid this
> particular duplication, which really isn't all that bad.
> 
> This patch also seems to have gotten lost in the shuffle of things, but
> it still applies cleanly and I took another look at it today and it
> looks good to me, so I'm going to stick it in the CF and mark it as
> Needs Review for now.  Perhaps someone else can give it another
> once-over to make sure everything looks good and, if so, mark it as
> Ready for Committer and then I'll take care of it.

I may be missing something, but no patch is attached to this
thread. Honestly I think that duplicating this code should be avoided,
and the patch to produce is not that complicated technically. So are you
planning to just duplicate hte definitions in CREATE TABLE to ALTER
TABLE? This is a recipy for forgetting updates in the future on one
page or the other...
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Missing column_constraint explanation
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox