From: Michael Paquier <michael@paquier.xyz>
To: Maksim Milyutin <milyutinma@gmail.com>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Typo in description of replay_lag attribute in pg_stat_replication view
Date: Tue, 4 Dec 2018 09:18:02 +0900
Message-ID: <20181204001802.GK3423@paquier.xyz> (raw)
In-Reply-To: <27b3b80c-3615-2d76-02c5-44566b53136c@gmail.com>
References: <27b3b80c-3615-2d76-02c5-44566b53136c@gmail.com>
On Mon, Dec 03, 2018 at 06:18:30PM +0300, Maksim Milyutin wrote:
> I have noticed that in description of *flush_lag* in pg_stat_replication
> view (https://www.postgresql.org/docs/current/monitoring-stats.html#PG-STAT-REPLICATION-VIEW)
> there exists unknown value of synchronous_commit parameter - *remote_flush*.
> I think it was meant to use the value *on*.
Yes, you are right. It should be "on" as "remote_flush" is not a valid
value. remote_flush is listed in SyncCommitLevel though, so this makes
me wonder if we should also introduce a new value for this purpose
available for users. The fix you propose looks good to me. Any
opinions from others?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: michael@paquier.xyz, milyutinma@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Typo in description of replay_lag attribute in pg_stat_replication view
In-Reply-To: <20181204001802.GK3423@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox