pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: pgsql-docs@postgresql.org <pgsql-docs@postgresql.org>
Subject: Re: Some typos in documentation
Date: Sun, 13 Jan 2019 09:34:36 +0900
Message-ID: <20190113003435.GA32588@paquier.xyz> (raw)
In-Reply-To: <9b5a3a85-899a-ae62-dbab-1e7943aa5ab1@gmail.com>
References: <9b5a3a85-899a-ae62-dbab-1e7943aa5ab1@gmail.com>

On Sun, Jan 13, 2019 at 12:17:07AM +0300, Alexander Lakhin wrote:
> While cross-checking the unique words in doc/ I found a few typos.

Those are good finds, thanks for the report!

> LockFileCreateWrite -- Should be spelled as LockFileCreateWRITE (as in
> pgstat.c) or LockFileCreateWRITE in pg.stat.s should use CamelCase in
> whole. I don't find any dependencies so I would prefer the latter.

For consistency with the rest I think that we should use
LockFileCreateWrite in pgstat.c as well as you do, though this could
be qualified as a behavior change.  That's also the grammar which is
documented since the beginning.  Any objections from others?

> All the corresponding patches are attached.

Cool, I'll see to apply them where needed.  I'll just wait to see if
anybody has comments about the pgstat.c portion.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (3+ messages)  latest in thread

Message-ID: <20190113003435.GA32588@paquier.xyz>
Permalink:  ../20190113003435.GA32588@paquier.xyz/
Also on:    postgresql.org/message-id/20190113003435.GA32588@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: michael@paquier.xyz, exclusion@gmail.com
  Subject: Re: Some typos in documentation
  In-Reply-To: <20190113003435.GA32588@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox