From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: phil.bayer@gmail.com, pgsql-docs@lists.postgresql.org, PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Postgres 11: Table Partitioning and Primary Keys
Date: Wed, 10 Jul 2019 16:13:07 +0900
Message-ID: <20190710071307.GB5042@paquier.xyz> (raw)
In-Reply-To: <1341.1562713199@sss.pgh.pa.us>
References: <20190709225333.GA18051@alvherre.pgsql>
<1341.1562713199@sss.pgh.pa.us>
On Tue, Jul 09, 2019 at 06:59:59PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> <listitem>
>> <para>
>> Unique constraints on partitioned tables (as well as primary keys)
>> must constrain all the partition key columns. This limitation exists
>> because <productname>PostgreSQL</productname> can only enforce
>> uniqueness in each partition individually.
>> </para>
>> </listitem>
>
>> I'm not really sure about the "must constrain" verbiage. Is that really
>> comprehensible?
>
> I think "must include" might be better.
+1.
>> which may not be the pinnacle of clarity, but took some time to craft
>> and I think is correct. Also it doesn't mention primary keys
>> explicitly; maybe we should patch it by adding "(as well as a primary
>> key)" right after "a unique constraint". Thoughts?
>
> I'd leave that alone. I don't think the parenthetical comment about
> primary keys in your new text is adding much either.
Agreed with not bothering about this block and not adding the
parenthetical comment.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190710071307.GB5042@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, amitlangote09@gmail.com, david.g.johnston@gmail.com, bruce@momjian.us, pgsql-hackers@postgresql.org
Subject: Re: Postgres 11: Table Partitioning and Primary Keys
In-Reply-To: <20190710071307.GB5042@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox