From: Michael Paquier <michael@paquier.xyz>
To: Liudmila Mantrova <l.mantrova@postgrespro.ru>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: misc doc fixes for REL_12_STABLE
Date: Fri, 12 Jul 2019 13:44:18 +0900
Message-ID: <20190712044418.GG2149@paquier.xyz> (raw)
In-Reply-To: <a068f947-7a51-5df1-b3fd-1a131ae5c044@postgrespro.ru>
References: <a068f947-7a51-5df1-b3fd-1a131ae5c044@postgrespro.ru>
On Thu, Jul 11, 2019 at 05:49:26PM +0300, Liudmila Mantrova wrote:
> Please consider a patch that fixes some trivial issues in new doc fragments
> (a couple of typos/ambiguities and some tags that affect translation).
Thanks for the patch. I have one comment.
> - backups. Moreover, because it writes a backup_label file on the
> - master, it can cause the master to fail to restart automatically after
> - a crash. On the other hand, the erroneous removal of a backup_label
> - file from a backup or standby is a common mistake which can result
> + backups. Moreover, because it creates a backup label file, as
> + described below, it can block automatic restart of the master server
> + after a crash. On the other hand, the erroneous removal of this
> + file from a backup or standby is a common mistake, which can result
> in serious data corruption. If it is necessary to use this method,
> the following steps may be used.
Okay, yes that could be a bit confusing for the reader. Nit: I would
replace "master" with "primary" while we are in the area. What do you
think?
But that's the only comment I have, the rest looks good!
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: michael@paquier.xyz, l.mantrova@postgrespro.ru, pgsql-docs@lists.postgresql.org
Subject: Re: misc doc fixes for REL_12_STABLE
In-Reply-To: <20190712044418.GG2149@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox