pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedwrong Visual Studio Edition 's name
8+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2019-08-22 37093766b2 39511da1c0 9d35bc5931 73ef3df16d c7d8245b09 9f4bf6d2af 157b233c44 Doc: Remove mention to "Visual Studio Express 2019"
* wrong Visual Studio Edition 's name
@ 2019-08-20 03:02 Takuma Hoshiai <hoshiai@sraoss.co.jp>
0 siblings, 1 reply; 8+ messages in thread
From: Takuma Hoshiai @ 2019-08-20 03:02 UTC (permalink / raw)
To: pgsql-docs
Hi all,
I perhaps found mistake in postgresql doucment.
In 'Installation from Source Code on Windows' chapter,
'Visual Studio Express 2019' is contained.
But Visual Studio Express exists until only 2017, so Express Edition on 2019
don't exist. I think that we shoud fix it to 'Visual Studio 2019' or
'Visual Studio Community 2019'.
Best Regards,
--
Takuma Hoshiai <hoshiai@sraoss.co.jp>
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: wrong Visual Studio Edition 's name
@ 2019-08-20 05:00 Michael Paquier <michael@paquier.xyz>
parent: Takuma Hoshiai <hoshiai@sraoss.co.jp>
0 siblings, 1 reply; 8+ messages in thread
From: Michael Paquier @ 2019-08-20 05:00 UTC (permalink / raw)
To: Takuma Hoshiai <hoshiai@sraoss.co.jp>; +Cc: pgsql-docs
On Tue, Aug 20, 2019 at 12:02:31PM +0900, Takuma Hoshiai wrote:
> In 'Installation from Source Code on Windows' chapter,
> 'Visual Studio Express 2019' is contained.
> But Visual Studio Express exists until only 2017, so Express Edition
> on 2019 does not exist. I think that we should fix it to 'Visual
> Studio 2019' or 'Visual Studio Community 2019'.
Okay, that sounds right. There are two places where we use this term.
I would just take the most simple wording and use "Visual Studio 2019"
for both. People would most likely understand what's behind it
anyway, and big M pushes with this formulation as far as I understood.
Perhaps others have thoughts to share?
Hoshiai-san, would you like to send a patch?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: wrong Visual Studio Edition 's name
@ 2019-08-20 05:20 Takuma Hoshiai <hoshiai@sraoss.co.jp>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 8+ messages in thread
From: Takuma Hoshiai @ 2019-08-20 05:20 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-docs
On Tue, 20 Aug 2019 14:00:45 +0900
Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Aug 20, 2019 at 12:02:31PM +0900, Takuma Hoshiai wrote:
> > In 'Installation from Source Code on Windows' chapter,
> > 'Visual Studio Express 2019' is contained.
> > But Visual Studio Express exists until only 2017, so Express Edition
> > on 2019 does not exist. I think that we should fix it to 'Visual
> > Studio 2019' or 'Visual Studio Community 2019'.
>
> Okay, that sounds right. There are two places where we use this term.
> I would just take the most simple wording and use "Visual Studio 2019"
> for both. People would most likely understand what's behind it
> anyway, and big M pushes with this formulation as far as I understood.
I think so,too. "Visual Studio 2019" is good.
> Perhaps others have thoughts to share?
>
> Hoshiai-san, would you like to send a patch?
OK, I will send a patch to this thread,right?
> --
> Michael
--
Takuma Hoshiai <hoshiai@sraoss.co.jp>
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: wrong Visual Studio Edition 's name
@ 2019-08-20 05:37 Michael Paquier <michael@paquier.xyz>
parent: Takuma Hoshiai <hoshiai@sraoss.co.jp>
0 siblings, 1 reply; 8+ messages in thread
From: Michael Paquier @ 2019-08-20 05:37 UTC (permalink / raw)
To: Takuma Hoshiai <hoshiai@sraoss.co.jp>; +Cc: pgsql-docs
On Tue, Aug 20, 2019 at 02:20:04PM +0900, Takuma Hoshiai wrote:
> OK, I will send a patch to this thread,right?
If you can send it here, that would be great.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: wrong Visual Studio Edition 's name
@ 2019-08-20 06:38 Takuma Hoshiai <hoshiai@sraoss.co.jp>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 8+ messages in thread
From: Takuma Hoshiai @ 2019-08-20 06:38 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-docs
On Tue, 20 Aug 2019 14:37:09 +0900
Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Aug 20, 2019 at 02:20:04PM +0900, Takuma Hoshiai wrote:
> > OK, I will send a patch to this thread,right?
>
> If you can send it here, that would be great.
> --
> Michael
I have attached a patch. The word of "Express" existed in four places, they will are fixed by this patch.
Best Regards,
--
Takuma Hoshiai <hoshiai@sraoss.co.jp>
Attachments:
vs_edition_fix.patch (application/octet-stream, 2.4K) download
diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml
index 0bbb314..05d10f7 100644
--- a/doc/src/sgml/install-windows.sgml
+++ b/doc/src/sgml/install-windows.sgml
@@ -19,9 +19,8 @@
<para>
There are several different ways of building PostgreSQL on
<productname>Windows</productname>. The simplest way to build with
- Microsoft tools is to install <productname>Visual Studio Express 2019
- for Windows Desktop</productname> and use the included
- compiler. It is also possible to build with the full
+ Microsoft tools is to install <productname>Visual Studio 2019</productname>
+ and use the included compiler. It is also possible to build with the full
<productname>Microsoft Visual C++ 2013 to 2019</productname>.
In some cases that requires the installation of the
<productname>Windows SDK</productname> in addition to the compiler.
@@ -65,12 +64,12 @@
<para>
PostgreSQL can be built using the Visual C++ compiler suite from Microsoft.
- These compilers can be either from <productname>Visual Studio</productname>,
- <productname>Visual Studio Express</productname> or some versions of the
- <productname>Microsoft Windows SDK</productname>. If you do not already have a
- <productname>Visual Studio</productname> environment set up, the easiest
- ways are to use the compilers from <productname>Visual Studio Express 2019
- for Windows Desktop</productname> or those in the <productname>Windows SDK
+ These compilers can be either from <productname>Visual Studio</productname>
+ or some versions of the <productname>Microsoft Windows SDK</productname>.
+ If you do not already have a <productname>Visual Studio</productname>
+ environment set up, the easiest ways are to use the compilers
+ from <productname>Visual Studio 2019</productname>
+ or those in the <productname>Windows SDK
10</productname>, which are both free downloads from Microsoft.
</para>
@@ -78,7 +77,7 @@
Both 32-bit and 64-bit builds are possible with the Microsoft Compiler suite.
32-bit PostgreSQL builds are possible with
<productname>Visual Studio 2013</productname> to
- <productname>Visual Studio 2019</productname> (including Express editions),
+ <productname>Visual Studio 2019</productname>,
as well as standalone Windows SDK releases 8.1a to 10.
64-bit PostgreSQL builds are supported with
<productname>Microsoft Windows SDK</productname> version 8.1a to 10 or
* Re: wrong Visual Studio Edition 's name
@ 2019-08-20 10:19 Michael Paquier <michael@paquier.xyz>
parent: Takuma Hoshiai <hoshiai@sraoss.co.jp>
0 siblings, 1 reply; 8+ messages in thread
From: Michael Paquier @ 2019-08-20 10:19 UTC (permalink / raw)
To: Takuma Hoshiai <hoshiai@sraoss.co.jp>; +Cc: pgsql-docs
On Tue, Aug 20, 2019 at 03:38:28PM +0900, Takuma Hoshiai wrote:
> I have attached a patch. The word of "Express" existed in four
> places, they will are fixed by this patch.
- These compilers can be either from <productname>Visual Studio</productname>,
- <productname>Visual Studio Express</productname> or some versions of the
- <productname>Microsoft Windows SDK</productname>. If you do not already have a
- <productname>Visual Studio</productname> environment set up, the easiest
- ways are to use the compilers from <productname>Visual Studio Express 2019
- for Windows Desktop</productname> or those in the <productname>Windows SDK
+ These compilers can be either from <productname>Visual Studio</productname>
+ or some versions of the <productname>Microsoft Windows SDK</productname>.
+ If you do not already have a <productname>Visual Studio</productname>
+ environment set up, the easiest ways are to use the compilers
+ from <productname>Visual Studio 2019</productname>
+ or those in the <productname>Windows SDK
10</productname>, which are both free downloads from Microsoft.
I may be missing something, but this refers to all the possible
flavors of VS where compilers are available, hence mentioning Visual
Studio Express is still correct when going through our full supported
range from VS 2013 to VS 2019, no? That's why I said only two places
need to be fixed, as this area is fine.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: wrong Visual Studio Edition 's name
@ 2019-08-21 04:03 Takuma Hoshiai <hoshiai@sraoss.co.jp>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 8+ messages in thread
From: Takuma Hoshiai @ 2019-08-21 04:03 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-docs
On Tue, 20 Aug 2019 19:19:01 +0900
Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Aug 20, 2019 at 03:38:28PM +0900, Takuma Hoshiai wrote:
> > I have attached a patch. The word of "Express" existed in four
> > places, they will are fixed by this patch.
>
> - These compilers can be either from <productname>Visual Studio</productname>,
> - <productname>Visual Studio Express</productname> or some versions of the
> - <productname>Microsoft Windows SDK</productname>. If you do not already have a
> - <productname>Visual Studio</productname> environment set up, the easiest
> - ways are to use the compilers from <productname>Visual Studio Express 2019
> - for Windows Desktop</productname> or those in the <productname>Windows SDK
> + These compilers can be either from <productname>Visual Studio</productname>
> + or some versions of the <productname>Microsoft Windows SDK</productname>.
> + If you do not already have a <productname>Visual Studio</productname>
> + environment set up, the easiest ways are to use the compilers
> + from <productname>Visual Studio 2019</productname>
> + or those in the <productname>Windows SDK
> 10</productname>, which are both free downloads from Microsoft.
>
> I may be missing something, but this refers to all the possible
> flavors of VS where compilers are available, hence mentioning Visual
> Studio Express is still correct when going through our full supported
> range from VS 2013 to VS 2019, no? That's why I said only two places
> need to be fixed, as this area is fine.
Yes, Express edition is contained by supported range. But my understanding
is that other Edition are also same. The reason for changing above sentence,
was that I thought that we don't need to specify Express edition only.
The above original sentence is no problem too, so I have reattached a patch,
which is fixed "Express 2019" only.
> --
> Michael
--
Takuma Hoshiai <hoshiai@sraoss.co.jp>
Attachments:
vs_edition_fix_v2.patch (application/octet-stream, 1.5K) download
diff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgml
index 0bbb314..c6e4afe 100644
--- a/doc/src/sgml/install-windows.sgml
+++ b/doc/src/sgml/install-windows.sgml
@@ -19,9 +19,8 @@
<para>
There are several different ways of building PostgreSQL on
<productname>Windows</productname>. The simplest way to build with
- Microsoft tools is to install <productname>Visual Studio Express 2019
- for Windows Desktop</productname> and use the included
- compiler. It is also possible to build with the full
+ Microsoft tools is to install <productname>Visual Studio 2019</productname>
+ and use the included compiler. It is also possible to build with the full
<productname>Microsoft Visual C++ 2013 to 2019</productname>.
In some cases that requires the installation of the
<productname>Windows SDK</productname> in addition to the compiler.
@@ -69,8 +68,8 @@
<productname>Visual Studio Express</productname> or some versions of the
<productname>Microsoft Windows SDK</productname>. If you do not already have a
<productname>Visual Studio</productname> environment set up, the easiest
- ways are to use the compilers from <productname>Visual Studio Express 2019
- for Windows Desktop</productname> or those in the <productname>Windows SDK
+ ways are to use the compilers from <productname>Visual Studio 2019</productname>
+ or those in the <productname>Windows SDK
10</productname>, which are both free downloads from Microsoft.
</para>
* Re: wrong Visual Studio Edition 's name
@ 2019-08-22 01:02 Michael Paquier <michael@paquier.xyz>
parent: Takuma Hoshiai <hoshiai@sraoss.co.jp>
0 siblings, 0 replies; 8+ messages in thread
From: Michael Paquier @ 2019-08-22 01:02 UTC (permalink / raw)
To: Takuma Hoshiai <hoshiai@sraoss.co.jp>; +Cc: pgsql-docs
On Wed, Aug 21, 2019 at 01:03:01PM +0900, Takuma Hoshiai wrote:
> The above original sentence is no problem too, so I have reattached a patch,
> which is fixed "Express 2019" only.
Thanks, applied down to 9.4. I have been hesitating about a third
place, and at the end included it in the set fixed.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2019-08-22 01:02 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 03:02 wrong Visual Studio Edition 's name Takuma Hoshiai <hoshiai@sraoss.co.jp>
2019-08-20 05:00 ` Michael Paquier <michael@paquier.xyz>
2019-08-20 05:20 ` Takuma Hoshiai <hoshiai@sraoss.co.jp>
2019-08-20 05:37 ` Michael Paquier <michael@paquier.xyz>
2019-08-20 06:38 ` Takuma Hoshiai <hoshiai@sraoss.co.jp>
2019-08-20 10:19 ` Michael Paquier <michael@paquier.xyz>
2019-08-21 04:03 ` Takuma Hoshiai <hoshiai@sraoss.co.jp>
2019-08-22 01:02 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox