From: Takuma Hoshiai <hoshiai@sraoss.co.jp>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-docs@postgresql.org
Subject: Re: wrong Visual Studio Edition 's name
Date: Wed, 21 Aug 2019 13:03:01 +0900
Message-ID: <20190821130301.43bded469ed4b4fdb879ae56@sraoss.co.jp> (raw)
In-Reply-To: <20190820101901.GB1684@paquier.xyz>
References: <20190820120231.f905542e685140258ca73d82@sraoss.co.jp>
<20190820050045.GB1841@paquier.xyz>
<20190820142004.2a5107c7fe3773df3066ddc9@sraoss.co.jp>
<20190820053709.GE1841@paquier.xyz>
<20190820153828.7ed0d6f4b2df797b1eeb93a7@sraoss.co.jp>
<20190820101901.GB1684@paquier.xyz>
On Tue, 20 Aug 2019 19:19:01 +0900
Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Aug 20, 2019 at 03:38:28PM +0900, Takuma Hoshiai wrote:
> > I have attached a patch. The word of "Express" existed in four
> > places, they will are fixed by this patch.
>
> - These compilers can be either from <productname>Visual Studio</productname>,
> - <productname>Visual Studio Express</productname> or some versions of the
> - <productname>Microsoft Windows SDK</productname>. If you do not already have a
> - <productname>Visual Studio</productname> environment set up, the easiest
> - ways are to use the compilers from <productname>Visual Studio Express 2019
> - for Windows Desktop</productname> or those in the <productname>Windows SDK
> + These compilers can be either from <productname>Visual Studio</productname>
> + or some versions of the <productname>Microsoft Windows SDK</productname>.
> + If you do not already have a <productname>Visual Studio</productname>
> + environment set up, the easiest ways are to use the compilers
> + from <productname>Visual Studio 2019</productname>
> + or those in the <productname>Windows SDK
> 10</productname>, which are both free downloads from Microsoft.
>
> I may be missing something, but this refers to all the possible
> flavors of VS where compilers are available, hence mentioning Visual
> Studio Express is still correct when going through our full supported
> range from VS 2013 to VS 2019, no? That's why I said only two places
> need to be fixed, as this area is fine.
Yes, Express edition is contained by supported range. But my understanding
is that other Edition are also same. The reason for changing above sentence,
was that I thought that we don't need to specify Express edition only.
The above original sentence is no problem too, so I have reattached a patch,
which is fixed "Express 2019" only.
> --
> Michael
--
Takuma Hoshiai <hoshiai@sraoss.co.jp>
Attachments:vs_edition_fix_v2.patch (application/octet-stream, 1.5K) downloaddiff --git a/doc/src/sgml/install-windows.sgml b/doc/src/sgml/install-windows.sgmlindex 0bbb314..c6e4afe 100644--- a/doc/src/sgml/install-windows.sgml+++ b/doc/src/sgml/install-windows.sgml@@ -19,9 +19,8 @@
<para>
There are several different ways of building PostgreSQL on
<productname>Windows</productname>. The simplest way to build with
- Microsoft tools is to install <productname>Visual Studio Express 2019- for Windows Desktop</productname> and use the included- compiler. It is also possible to build with the full+ Microsoft tools is to install <productname>Visual Studio 2019</productname>+ and use the included compiler. It is also possible to build with the full
<productname>Microsoft Visual C++ 2013 to 2019</productname>.
In some cases that requires the installation of the
<productname>Windows SDK</productname> in addition to the compiler.
@@ -69,8 +68,8 @@
<productname>Visual Studio Express</productname> or some versions of the
<productname>Microsoft Windows SDK</productname>. If you do not already have a
<productname>Visual Studio</productname> environment set up, the easiest
- ways are to use the compilers from <productname>Visual Studio Express 2019- for Windows Desktop</productname> or those in the <productname>Windows SDK+ ways are to use the compilers from <productname>Visual Studio 2019</productname>+ or those in the <productname>Windows SDK
10</productname>, which are both free downloads from Microsoft.
</para>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: hoshiai@sraoss.co.jp, michael@paquier.xyz
Subject: Re: wrong Visual Studio Edition 's name
In-Reply-To: <20190821130301.43bded469ed4b4fdb879ae56@sraoss.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox