pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedDelete description of trigger file
4+ messages / 2 participants
[nested] [flat]
* Delete description of trigger file
@ 2023-12-01 02:54 Shinya Kato <Shinya11.Kato@oss.nttdata.com>
2023-12-01 07:01 ` Re: Delete description of trigger file Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 4+ messages in thread
From: Shinya Kato @ 2023-12-01 02:54 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
Hi,
Standby database promotion by trigger file creation is no longer
supported from v16, but its description is remained.
So, I created a patch. Do you think?
--
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION
Attachments:
[text/x-diff] v1-0001-delete-description-of-trigger-file.patch (641B, ../../201b08ea29aa61f96162080e75be503c@oss.nttdata.com/2-v1-0001-delete-description-of-trigger-file.patch)
download | inline diff:
diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index eb81260bbf..bd6e61ba8a 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -648,7 +648,7 @@ protocol to make nodes agree on a serializable transactional order.
later disconnected, the standby goes back to step 1 and tries to
restore the file from the archive again. This loop of retries from the
archive, <filename>pg_wal</filename>, and via streaming replication goes on until the server
- is stopped or failover is triggered by a trigger file.
+ is stopped.
</para>
<para>
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Delete description of trigger file
2023-12-01 02:54 Delete description of trigger file Shinya Kato <Shinya11.Kato@oss.nttdata.com>
@ 2023-12-01 07:01 ` Michael Paquier <michael@paquier.xyz>
2023-12-02 08:52 ` Re: Delete description of trigger file Shinya Kato <Shinya11.Kato@oss.nttdata.com>
0 siblings, 1 reply; 4+ messages in thread
From: Michael Paquier @ 2023-12-01 07:01 UTC (permalink / raw)
To: Shinya Kato <Shinya11.Kato@oss.nttdata.com>; +Cc: pgsql-docs@lists.postgresql.org
On Fri, Dec 01, 2023 at 11:54:14AM +0900, Shinya Kato wrote:
> later disconnected, the standby goes back to step 1 and tries to
> restore the file from the archive again. This loop of retries from the
> archive, <filename>pg_wal</filename>, and via streaming replication goes on until the server
> - is stopped or failover is triggered by a trigger file.
> + is stopped.
Just removing this information looks incorrect to me, because a
promotion would cause the retries to stop the WAL lookups. Shouldn't
the last part of this sentence be reworded as of a "or is promoted"?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../ZWmExMaaD-NOAdBx@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Delete description of trigger file
2023-12-01 02:54 Delete description of trigger file Shinya Kato <Shinya11.Kato@oss.nttdata.com>
2023-12-01 07:01 ` Re: Delete description of trigger file Michael Paquier <michael@paquier.xyz>
@ 2023-12-02 08:52 ` Shinya Kato <Shinya11.Kato@oss.nttdata.com>
2023-12-03 23:11 ` Re: Delete description of trigger file Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 4+ messages in thread
From: Shinya Kato @ 2023-12-02 08:52 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pgsql-docs@lists.postgresql.org
On 2023-12-01 16:01, Michael Paquier wrote:
> On Fri, Dec 01, 2023 at 11:54:14AM +0900, Shinya Kato wrote:
>> later disconnected, the standby goes back to step 1 and tries to
>> restore the file from the archive again. This loop of retries
>> from the
>> archive, <filename>pg_wal</filename>, and via streaming
>> replication goes on until the server
>> - is stopped or failover is triggered by a trigger file.
>> + is stopped.
>
> Just removing this information looks incorrect to me, because a
> promotion would cause the retries to stop the WAL lookups. Shouldn't
> the last part of this sentence be reworded as of a "or is promoted"?
Thanks for the review.
Yes, that's true. A new patch is attached.
--
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION
Attachments:
[text/x-diff] v2-0001-delete-description-of-trigger-file.patch (656B, ../../e9c01f395044a75c4eb6a6a130c24cfa@oss.nttdata.com/2-v2-0001-delete-description-of-trigger-file.patch)
download | inline diff:
diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index eb81260bbf..9dd52ff275 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -648,7 +648,7 @@ protocol to make nodes agree on a serializable transactional order.
later disconnected, the standby goes back to step 1 and tries to
restore the file from the archive again. This loop of retries from the
archive, <filename>pg_wal</filename>, and via streaming replication goes on until the server
- is stopped or failover is triggered by a trigger file.
+ is stopped or is promoted.
</para>
<para>
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Delete description of trigger file
2023-12-01 02:54 Delete description of trigger file Shinya Kato <Shinya11.Kato@oss.nttdata.com>
2023-12-01 07:01 ` Re: Delete description of trigger file Michael Paquier <michael@paquier.xyz>
2023-12-02 08:52 ` Re: Delete description of trigger file Shinya Kato <Shinya11.Kato@oss.nttdata.com>
@ 2023-12-03 23:11 ` Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 4+ messages in thread
From: Michael Paquier @ 2023-12-03 23:11 UTC (permalink / raw)
To: Shinya Kato <Shinya11.Kato@oss.nttdata.com>; +Cc: pgsql-docs@lists.postgresql.org
On Sat, Dec 02, 2023 at 05:52:50PM +0900, Shinya Kato wrote:
> Thanks for the review.
> Yes, that's true. A new patch is attached.
Thanks, applied.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../ZW0LLFc3wzPnfgJp@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2023-12-03 23:11 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-12-01 02:54 Delete description of trigger file Shinya Kato <Shinya11.Kato@oss.nttdata.com>
2023-12-01 07:01 ` Michael Paquier <michael@paquier.xyz>
2023-12-02 08:52 ` Shinya Kato <Shinya11.Kato@oss.nttdata.com>
2023-12-03 23:11 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox