pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Delete description of trigger file
Date: Sat, 02 Dec 2023 17:52:50 +0900
Message-ID: <e9c01f395044a75c4eb6a6a130c24cfa@oss.nttdata.com> (raw)
In-Reply-To: <ZWmExMaaD-NOAdBx@paquier.xyz>
References: <201b08ea29aa61f96162080e75be503c@oss.nttdata.com>
	<ZWmExMaaD-NOAdBx@paquier.xyz>

On 2023-12-01 16:01, Michael Paquier wrote:
> On Fri, Dec 01, 2023 at 11:54:14AM +0900, Shinya Kato wrote:
>>      later disconnected, the standby goes back to step 1 and tries to
>>      restore the file from the archive again. This loop of retries 
>> from the
>>      archive, <filename>pg_wal</filename>, and via streaming 
>> replication goes on until the server
>> -    is stopped or failover is triggered by a trigger file.
>> +    is stopped.
> 
> Just removing this information looks incorrect to me, because a
> promotion would cause the retries to stop the WAL lookups.  Shouldn't
> the last part of this sentence be reworded as of a "or is promoted"?

Thanks for the review.
Yes, that's true. A new patch is attached.

-- 
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION

Attachments:

  [text/x-diff] v2-0001-delete-description-of-trigger-file.patch (656B, ../e9c01f395044a75c4eb6a6a130c24cfa@oss.nttdata.com/2-v2-0001-delete-description-of-trigger-file.patch)
  download | inline diff:
diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index eb81260bbf..9dd52ff275 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -648,7 +648,7 @@ protocol to make nodes agree on a serializable transactional order.
     later disconnected, the standby goes back to step 1 and tries to
     restore the file from the archive again. This loop of retries from the
     archive, <filename>pg_wal</filename>, and via streaming replication goes on until the server
-    is stopped or failover is triggered by a trigger file.
+    is stopped or is promoted.
    </para>
 
    <para>


view thread (4+ messages)  latest in thread

Message-ID: <e9c01f395044a75c4eb6a6a130c24cfa@oss.nttdata.com>
Permalink:  ../e9c01f395044a75c4eb6a6a130c24cfa@oss.nttdata.com/
Also on:    postgresql.org/message-id/e9c01f395044a75c4eb6a6a130c24cfa@oss.nttdata.com

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: Shinya11.Kato@oss.nttdata.com, michael@paquier.xyz, pgsql-docs@lists.postgresql.org
  Subject: Re: Delete description of trigger file
  In-Reply-To: <e9c01f395044a75c4eb6a6a130c24cfa@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox